delta/node-new.git/src/node_v8.cc, branch try_Python3_on_macOS

src: use non-deprecated overload of V8::SetFlagsFromString

2019-08-01T10:56:53+00:00

PR-URL: https://github.com/nodejs/node/pull/28016
Reviewed-By: Colin Ihrig 
Reviewed-By: Refael Ackermann (רפאל פלחי) 
Reviewed-By: Rich Trott 
Reviewed-By: Michael Dawson 
Reviewed-By: Jiawen Geng

src: export v8.GetHeapCodeAndMetadataStatistics()

2019-07-30T18:36:51+00:00

Export statistic provided by V8 through HeapCodeStatistics class and
and GetHeapCodeAndMetadataStatistics function to v8 Node.js module

PR-URL: https://github.com/nodejs/node/pull/27978
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung 
Reviewed-By: Rich Trott

src: export number_of_native_contexts and number_of_detached_contexts

2019-05-30T13:25:55+00:00

export number_of_native_contexts and number_of_detached_contexts as
part of v8.getHeapStatistics()

PR-URL: https://github.com/nodejs/node/pull/27933
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: fix type mismatch warnings from missing priv

2018-12-04T03:44:15+00:00

Registration initialization functions are expected to have a 4th
argument, a void*, so add them where necessary to fix the warnings.

PR-URL: https://github.com/nodejs/node/pull/24737
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: fix v8 compiler warnings in src

2018-11-11T07:02:30+00:00

This commit changes the code to use the maybe version.

PR-URL: https://github.com/nodejs/node/pull/24246
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

v8: move process.binding('v8') to internalBinding

2018-08-18T23:27:11+00:00

PR-URL: https://github.com/nodejs/node/pull/22288
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Colin Ihrig 
Reviewed-By: Jon Moss 
Reviewed-By: Joyee Cheung 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Anna Henningsen

src: start annotating native code side effect

2018-06-26T03:15:35+00:00

PR-URL: https://github.com/nodejs/node/pull/21458
Refs: https://github.com/nodejs/node/issues/20977
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

src: do not cache `NumberOfHeapSpaces()` globally

2018-06-01T09:22:31+00:00

While `NumberOfHeapSpaces()` currently returns a constant value,
that is not strictly guaranteed by the V8 API as far as I can tell.
Therefore, caching it globally does not seem appropriate.

(The motivation here is that this squelches warnings which are
produced by concurrency debugging tooling due to the apparent
race conditions when accessing the global variable.)

PR-URL: https://github.com/nodejs/node/pull/20971
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell