delta/node-new.git/src/node_url.h, branch crypto_set_integer_macro

url: use foreach-style C++ loop

2018-10-01T13:30:15+00:00

PR-URL: https://github.com/nodejs/node/pull/23138
Reviewed-By: Refael Ackermann 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

src: added URL::FromFilePath method

2018-09-14T15:32:08+00:00

Method returns file URL from native file path.

PR-URL: https://github.com/nodejs/node/pull/22251
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Tiancheng "Timothy" Gu

url: introduce `URL_FLAGS_IS_DEFAULT_SCHEME_PORT` flag

2018-05-18T13:24:05+00:00

Introduce `URL_FLAGS_IS_DEFAULT_SCHEME_PORT` flag which is retured
when the parser detects that the port passed is the default port
for that scheme.

PR-URL: https://github.com/nodejs/node/pull/20479
Fixes: https://github.com/nodejs/node/issues/20465
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ruben Bridgewater

src: improve module loader readability

2017-11-03T00:10:31+00:00

Various improvements on readability, performance and
conformity to the Node core coding style in the ESM loader C++ code:

- `isolate` for the `Isolate*`, `context` for the `Local`
- Less reliance on `auto` where it’s unnecessary/increases cognitive
  overhead
- Shorter paths to failure via `.ToLocal()` & co
- Do not keep pending exceptions around e.g. for failed `JSON` parsing
- Use `Maybe` types to get explicit error status forwarding
- Remove an unnecessary handle scope
- Add `nullptr` checks for unwrapped host objects
- Remove unused code
- Use `CamelCase` for function names
- Use `const Foo&` instead of copying values whenever possible
- Pass along the `Environment*` explicitly

PR-URL: https://github.com/nodejs/node/pull/16536
Reviewed-By: Stephen Belanger 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen 
Reviewed-By: Gireesh Punathil

src: do not include x.h if x-inl.h is included

2017-10-30T10:56:38+00:00

PR-URL: https://github.com/nodejs/node/pull/16548
Fixes: https://github.com/nodejs/node/issues/16519
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Colin Ihrig

url: const-ify APIs, and pass URL by ref

2017-10-01T23:20:06+00:00

Fixes warnings by Coverity Scan of inefficiences when passing by value
instead of passing by const reference.

PR-URL: https://github.com/nodejs/node/pull/15615
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Timothy Gu 
Reviewed-By: Evan Lucas

module: Allow runMain to be ESM

2017-09-07T20:18:32+00:00

This follows the EPS an allows the node CLI to have ESM as an entry point.
`node ./example.mjs`. A newer V8 is needed for `import()` so that is not
included. `import.meta` is still in specification stage so that also is not
included.

PR-URL: https://github.com/nodejs/node/pull/14369
Author: Bradley Farias 
Author: Guy Bedford 
Author: Jan Krems 
Author: Timothy Gu 
Author: Michaël Zasso 
Author: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel

url: fix C0 control and whitespace handling

2017-05-20T06:19:57+00:00

PR-URL: https://github.com/nodejs/node/pull/12846
Fixes: https://github.com/nodejs/node/issues/12825
Refs: https://github.com/w3c/web-platform-tests/pull/5792
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: clean up WHATWG WG parser

2017-04-17T16:11:56+00:00

* reduce indentation
* refactor URL inlined methods
* prefer templates over macros
* do not export ARG_* flags in url binding

PR-URL: https://github.com/nodejs/node/pull/12251
Reviewed-By: Anna Henningsen 
Reviewed-By: Daijiro Wachi 
Reviewed-By: James M Snell

src: WHATWG URL C++ parser cleanup

2017-03-30T05:19:33+00:00

- Clarify port state
- Remove scheme flag
- Clarify URL_FLAG_TERMINATED

PR-URL: https://github.com/nodejs/node/pull/11917
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung