delta/node-new.git/src/node_url.cc, branch crypto_set_integer_macro

src: reduce variable scope in node_url.cc

2018-10-09T12:33:23+00:00

PR-URL: https://github.com/nodejs/node/pull/23297
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

src: added URL::FromFilePath method

2018-09-14T15:32:08+00:00

Method returns file URL from native file path.

PR-URL: https://github.com/nodejs/node/pull/22251
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Tiancheng "Timothy" Gu

url: move process.binding('url') to internalBinding

2018-09-07T01:03:25+00:00

PR-URL: https://github.com/nodejs/node/pull/22204
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: John-David Dalton

src: encode 0x27 (') for special URLs

2018-08-18T19:18:05+00:00

Refs: https://github.com/whatwg/url/commit/6ef17ebe1220a7e7c0cfff0785017502ee18808b
PR-URL: https://github.com/nodejs/node/pull/22022
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca

src: start annotating native code side effect

2018-06-26T03:15:35+00:00

PR-URL: https://github.com/nodejs/node/pull/21458
Refs: https://github.com/nodejs/node/issues/20977
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

url: introduce `URL_FLAGS_IS_DEFAULT_SCHEME_PORT` flag

2018-05-18T13:24:05+00:00

Introduce `URL_FLAGS_IS_DEFAULT_SCHEME_PORT` flag which is retured
when the parser detects that the port passed is the default port
for that scheme.

PR-URL: https://github.com/nodejs/node/pull/20479
Fixes: https://github.com/nodejs/node/issues/20465
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ruben Bridgewater

src: replace `template<` → `template <`

2018-05-14T16:09:23+00:00

PR-URL: https://github.com/nodejs/node/pull/20675
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Tobias Nießen 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ruben Bridgewater

src: general C++ cleanup in node_url.cc

2018-03-30T12:30:40+00:00

- Merge `domain` and `opaque` storage in URL parser:

  This just simplifies the code a bit, having multiple fields
  in an union with the same type is usually just overhead.

- Add move variant of `URLHost::ToString()`:

  This helps avoid unnecessary string copy operations, especially
  since we control the lifetime of `URLHost` objects pretty well.

- Use const refs in node_url.cc where appropriate

- Remove or reduce overly generous `.reserve()` calls:

  These would otherwise keep a lot of unused memory lying around.

- Return return values instead of unnecessary pointer arguments

- Use more common/expressive variable names

- Avoid macro use, reduce number of unnecessary JS strings:

  There’s no reason for `GET`, `GET_AND_SET` and `UTF8STRING` to be
  macros. Also, `GET` would previously create a JS string instance
  for each single call, even though the strings it was called
  with were compile-time constants.

- Avoid unnecessary JS casts when the type of a value is known

- Avoid (commonly unnecessary) copy for whitespace stripping

PR-URL: https://github.com/nodejs/node/pull/19598
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Daniel Bevenius

src: name all builtin init functions Initialize

2018-03-26T06:23:49+00:00

This commit renames a few of the builtin modules init functions to
Initialize for consistency.

PR-URL: https://github.com/nodejs/node/pull/19550
Reviewed-By: Anna Henningsen 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell

src: put bootstrappers in lib/internal/bootstrap/

2018-03-15T12:50:34+00:00

Create `lib/internal/bootstrap/` and put bootstrappers there:

Before:

```
lib/internal
├── ...
├── bootstrap_loaders.js
└── bootstrap_node.js
```

After:

```
lib/internal
├── ...
└── bootstrap
    ├── loaders.js
    └── node.js
```

PR-URL: https://github.com/nodejs/node/pull/19177
Refs: https://github.com/nodejs/node/pull/19112
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum