delta/node-new.git/src/node_url.cc, branch Ninja.py-StringIO

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-use-emplace

2019-03-21T06:23:44+00:00

PR-URL: https://github.com/nodejs/node/pull/26564
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung

src: de-lint header usage

2019-03-12T13:57:19+00:00

PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: simplify JS Array creation

2019-01-02T13:46:14+00:00

Use `ToV8Value()` where appropriate to reduce duplication
and avoid extra `Array::Set()` calls.

PR-URL: https://github.com/nodejs/node/pull/25288
Reviewed-By: Gus Caplan 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: pass along MaybeLocal<> state from `URL::ToObject()`

2018-12-31T00:10:36+00:00

PR-URL: https://github.com/nodejs/node/pull/25141
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: use custom TryCatch subclass

2018-12-03T16:25:06+00:00

PR-URL: https://github.com/nodejs/node/pull/24751
Reviewed-By: Joyee Cheung

src: use arraysize instead of hardcode number

2018-12-01T17:57:00+00:00

PR-URL: https://github.com/nodejs/node/pull/24473
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

url: reuse existing context in href setter

2018-12-01T16:53:05+00:00

Correctness-wise, this removes side effects in the href setter if
parsing fails. Style-wise, this allows removing the parse() wrapper
function around C++ _parse().

Also fix an existing bug with whitespace trimming in C++ that was
previously circumvented by additionally trimming the input in
JavaScript.

Fixes: https://github.com/nodejs/node/issues/24345
Refs: https://github.com/nodejs/node/pull/24218#issuecomment-438476591

PR-URL: https://github.com/nodejs/node/pull/24495
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Gus Caplan 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell