delta/node-new.git/src/node_stat_watcher.cc, branch crypto_set_integer_macro

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: replace deprecated uses of FunctionTemplate::GetFunction

2018-09-24T03:44:28+00:00

PR-URL: https://github.com/nodejs/node/pull/22993
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: add HandleWrap::AddWrapMethods

2018-07-13T16:08:20+00:00

Extracts common setters to a single location

PR-URL: https://github.com/nodejs/node/pull/21769
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

src: remove unused argc var in node_stat_watcher

2018-06-17T04:57:39+00:00

Currently the following compiler warning is reported:
../src/node_stat_watcher.cc:113:13: warning:
unused variable 'argc' [-Wunused-variable]
  const int argc = args.Length();
            ^
1 warning generated.

This commit removes the unused argc variable.

PR-URL: https://github.com/nodejs/node/pull/21337
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

lib,src: make `StatWatcher` a `HandleWrap`

2018-06-14T11:19:17+00:00

Wrapping libuv handles is what `HandleWrap` is there for.
This allows a decent reduction of state tracking machinery
by moving active-ness tracking to JS, and removing all
interaction with garbage collection.

Refs: https://github.com/nodejs/node/pull/21093

PR-URL: https://github.com/nodejs/node/pull/21244
Reviewed-By: Colin Ihrig 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: do not persist fs_poll handle in stat_watcher

2018-06-10T02:09:46+00:00

Instead of relying on garbage collection to close the handle,
manage its state more explicitly.

PR-URL: https://github.com/nodejs/node/pull/21093
Fixes: https://github.com/nodejs/node/issues/18190
Refs: https://github.com/nodejs/node/pull/18307
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig

fs: support BigInt in fs.*stat and fs.watchFile

2018-06-07T14:05:23+00:00

Add the `bigint: true` option to all the `fs.*stat` methods and
`fs.watchFile`.

PR-URL: https://github.com/nodejs/node/pull/20220
Fixes: https://github.com/nodejs/node/issues/12115
Reviewed-By: Ben Noordhuis

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26T10:29:31+00:00

This change introduces CHECK_NULL and CHECK_NOT_NULL macros
similar to their definition in v8 and replaces instances of
CHECK/CHECK_EQ/CHECK_NE with these where it seems appropriate.

PR-URL: https://github.com/nodejs/node/pull/20914
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

src: make CleanupHandles() tear down handles/reqs

2018-05-10T12:15:16+00:00

Previously, handles would not be closed when the current `Environment`
stopped, which is acceptable in a single-`Environment`-per-process
situation, but would otherwise create memory and file descriptor
leaks.

Also, introduce a generic way to close handles via the
`Environment::CloseHandle()` function, which automatically keeps
track of whether a close callback has been called yet or not.

Many thanks for Stephen Belanger for reviewing the original version of
this commit in the Ayo.js project.

Refs: https://github.com/ayojs/ayo/pull/85
PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

src: refactor `BaseObject` internal field management

2018-05-03T22:57:39+00:00

- Instead of storing a pointer whose type refers to the specific
  subclass of `BaseObject`, just store a `BaseObject*` directly.
  This means in particular that one can cast to classes along
  the way of the inheritance chain without issues, and that
  `BaseObject*` no longer needs to be the first superclass
  in the case of multiple inheritance.

  In particular, this renders hack-y solutions to this problem (like
  ddc19be6de1ba263d9c175b2760696e7b9918b25) obsolete and addresses
  a `TODO` comment of mine.

- Move wrapping/unwrapping methods to the `BaseObject` class.
  We use these almost exclusively for `BaseObject`s, and I hope
  that this gives a better idea of how (and for what) these are used
  in our code.

- Perform initialization/deinitialization of the internal field
  in the `BaseObject*` constructor/destructor. This makes the code
  a bit more obviously correct, avoids explicit calls for this
  in subclass constructors, and in particular allows us to avoid
  crash situations when we previously called `ClearWrap()`
  during GC.

  This also means that we enforce that the object passed to the
  `BaseObject` constructor needs to have an internal field.
  This is the only reason for the test change.

- Change the signature of `MakeWeak()` to not require a pointer
  argument. Previously, this would always have been the same
  as `this`, and no other value made sense. Also, the parameter
  was something that I personally found somewhat confusing
  when becoming familiar with Node’s code.

- Add a `TODO` comment that motivates switching to real inheritance
  for the JS types we expose from the native side. This patch
  brings us a lot closer to being able to do that.

- Some less significant drive-by cleanup.

Since we *effectively* already store the `BaseObject*` pointer
anyway since ddc19be6de1ba263d9c175b2760696e7b9918b25, I do not
think that this is going to have any impact on diagnostic tooling.

Fixes: https://github.com/nodejs/node/issues/18897
PR-URL: https://github.com/nodejs/node/pull/20455
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Daniel Bevenius