delta/node-new.git/src/node_serdes.cc, branch try_Python3_on_macOS

src: use ArrayBufferViewContents more frequently

2019-05-29T17:28:38+00:00

Using `ArrayBufferViewContents` over
`Buffer::Data()`/`Buffer::Length()` or `SPREAD_BUFFER_ARG` has the
advantages of creating fewer individual variables to keep track off,
not being a “magic” macro that creates variables, reducing code size,
and being faster when receiving on-heap TypedArrays.

PR-URL: https://github.com/nodejs/node/pull/27920
Reviewed-By: Ben Noordhuis 
Reviewed-By: Sam Roberts 
Reviewed-By: Colin Ihrig

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: allocate Buffer memory using ArrayBuffer allocator

2019-02-25T01:01:11+00:00

Always use the right allocator for memory that is turned into
an `ArrayBuffer` at a later point.

This enables embedders to use their own `ArrayBuffer::Allocator`s,
and is inspired by Electron’s electron/node@f61bae3440e. It should
render their downstream patch unnecessary.

Refs: https://github.com/electron/node/commit/f61bae3440e1bfcc83bba6ff0785adfb89b4045e

PR-URL: https://github.com/nodejs/node/pull/26207
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: apply clang-tidy rule modernize-use-override

2019-02-18T04:43:22+00:00

PR-URL: https://github.com/nodejs/node/pull/26103
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

v8: enable inline WASM in serialization API

2019-01-05T23:52:57+00:00

Since the API we expose through the `v8` module is Buffer-based,
we cannot transfer WASM modules directly. Instead, we enable
the V8-provided inline WASM (de)serialization for WASM modules.

PR-URL: https://github.com/nodejs/node/pull/25313
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan

src: use isolate version of BooleanValue()

2018-12-09T06:42:05+00:00

This fixes deprecation warnings.

PR-URL: https://github.com/nodejs/node/pull/24883
Reviewed-By: Michaël Zasso 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: explicitly allow JS in ReadHostObject

2018-12-06T14:26:02+00:00

PR-URL: https://github.com/nodejs/node/pull/23423
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Myles Borins

src: fix type mismatch warnings from missing priv

2018-12-04T03:44:15+00:00

Registration initialization functions are expected to have a 4th
argument, a void*, so add them where necessary to fix the warnings.

PR-URL: https://github.com/nodejs/node/pull/24737
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig