delta/node-new.git/src/node_revert.h, branch try_Python3_on_macOS

http2: remove security revert flags

2019-08-18T23:09:28+00:00

As the comment in `node_revert.h` indicates, the master branch should
not provide security revert flags.

Refs: https://github.com/nodejs/node/pull/29122

PR-URL: https://github.com/nodejs/node/pull/29141
Reviewed-By: Beth Griggs 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Gus Caplan 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell

http2: allow security revert for Ping/Settings Flood

2019-08-15T07:51:53+00:00

nghttp2 has updated its limit for outstanding Ping/Settings ACKs
to 1000. This commit allows reverting to the old default of 10000.

The associated CVEs are CVE-2019-9512/CVE-2019-9515.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: consider 0-length non-end DATA frames an error

2019-08-15T07:51:53+00:00

This is intended to mitigate CVE-2019-9518.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: handle 0-length headers better

2019-08-15T07:51:52+00:00

Ignore headers with 0-length names and track memory for headers
the way we track it for other HTTP/2 session memory too.

This is intended to mitigate CVE-2019-9516.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: limit number of rejected stream openings

2019-08-15T07:50:30+00:00

Limit the number of streams that are rejected upon creation. Since
each such rejection is associated with an `NGHTTP2_ENHANCE_YOUR_CALM`
error that should tell the peer to not open any more streams,
continuing to open streams should be read as a sign of a misbehaving
peer. The limit is currently set to 100 but could be changed or made
configurable.

This is intended to mitigate CVE-2019-9514.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

src: pass along errors from `--security-reverts`

2019-01-22T21:53:26+00:00

Pass along errors from `Revert()` when a security revert
is unknown (which currently applies to all possible values).

Previously, we would unconditionally call `exit()`, which is
not nice for embedding use cases, and could crash because we
were holding a lock for a mutex in `ProcessGlobalArgs()` that
would be destroyed by calling `exit()`.

Also, add a regression test that makes sure that the process
exits with the right exit code and not a crash.

PR-URL: https://github.com/nodejs/node/pull/25466
Reviewed-By: Richard Lau 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: move per-process global variables into node::per_process

2019-01-07T23:28:16+00:00

So that it's easier to tell whether we are manipulating per-process
global states that may need to be treated with care to avoid races.

Also added comments about these variables and moved some of them
to a more suitable compilation unit:

- Move `v8_initialized` to `util.h` since it's only used in
  `util.cc` and `node.cc`
- Rename `process_mutex` to `tty_mutex` and move it into
  `node_errors.cc` since that's the only place it's used
  to guard the tty.
- Move `per_process_opts_mutex` and `per_process_opts`
  into `node_options.h` and rename them to
  `per_process::cli_options[_mutex]`
- Rename `node_isolate[_mutex]` to `per_process::main_isolate[_mutex]`

PR-URL: https://github.com/nodejs/node/pull/25302
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis

meta: merge TSC and CTC back into a single body

2017-08-29T15:39:25+00:00

PR-URL: https://github.com/nodejs/node/pull/14973
Reviewed-By: Gireesh Punathil 
Reviewed-By: Matteo Collina 
Reviewed-By: Evan Lucas 
Reviewed-By: Rich Trott 
Reviewed-By: Myles Borins 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Shigeki Ohtsu 
Reviewed-By: Fedor Indutny

src: minor cleanup for node_revert

2017-08-18T22:02:12+00:00

Make the revert related functions inline to eliminate the need
for node_revert.cc, prefix the constants and the def, other misc
cleanup

PR-URL: https://github.com/nodejs/node/pull/14864
Reviewed-By: Anna Henningsen

src: add include guards to internal headers

2016-05-25T07:54:24+00:00

For consistency with the newly added src/base64.h header, check that
NODE_WANT_INTERNALS is defined and set in internal headers.

PR-URL: https://github.com/nodejs/node/pull/6948
Refs: https://github.com/nodejs/node/pull/6910
Reviewed-By: Fedor Indutny 
Reviewed-By: James M Snell 
Reviewed-By: Trevor Norris