delta/node-new.git/src/node_report_module.cc, branch docs-fix

src,doc,test: remove String::New default parameter

2020-07-14T13:13:34+00:00

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f

PR-URL: https://github.com/nodejs/node/pull/34248
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell

src: add errorProperties on process.report

2020-06-26T17:06:22+00:00

PR-URL: https://github.com/nodejs/node/pull/28426
Reviewed-By: Gireesh Punathil 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

report: add missing locks for report_on_fatalerror accessors

2020-04-02T15:46:30+00:00

Overlooked in 2fa74e3e38bb028339e48763138456b3ed10ed97.

Refs: https://github.com/nodejs/node/pull/32207

PR-URL: https://github.com/nodejs/node/pull/32535
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: handle report options on fatalerror

2020-03-31T18:59:25+00:00

Follow on to https://github.com/nodejs/node/pull/32207, 3 other options
are also not respected under situations that the isolate is not
available.

PR-URL: https://github.com/nodejs/node/pull/32497
Reviewed-By: Gireesh Punathil 
Reviewed-By: Richard Lau 
Reviewed-By: Anna Henningsen

src: fix compiler warnings in node_report_module

2020-03-28T13:41:14+00:00

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: https://github.com/nodejs/node/pull/32498
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Jiawen Geng 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell

report: handle on-fatalerror better

2020-03-25T19:43:45+00:00

--report-on-fatalerror was not honored properly, as there was no
way to check the value which was stored in the Environment pointer
which can be inaccessible under certain fatal error situations.

Move the flag out of Environment pointer so that this is doable.

Co-authored-by: Shobhit Chittora schittora@paypal.com

PR-URL: https://github.com/nodejs/node/pull/32207
Fixes: https://github.com/nodejs/node/issues/31576
Refs: https://github.com/nodejs/node/pull/29881
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sam Roberts

src,cli: support compact (one-line) JSON reports

2020-03-17T15:42:41+00:00

Multi-line JSON is more human readable, but harder for log aggregators
to consume, they usually require a log message per line, particularly
for JSON. Compact output will be consumable by aggregators such as EFK
(Elastic Search-Fluentd-Kibana), LogDNA, DataDog, etc.

PR-URL: https://github.com/nodejs/node/pull/32254
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: fix warning on mismatched fn signature

2019-04-01T04:34:01+00:00

Add the missing `void* priv` to node_report's Initialize().

PR-URL: https://github.com/nodejs/node/pull/26950
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Yongsheng Zhang