delta/node-new.git/src/node_report.cc, branch Ninja.py-StringIO

report: list envvars using uv_os_environ()

2019-08-11T18:18:36+00:00

This commit simplifies the diagnostic report's code for listing
environment variables by using uv_os_environ() instead of
platform specific code.

PR-URL: https://github.com/nodejs/node/pull/28963
Reviewed-By: Saúl Ibarra Corretgé 
Reviewed-By: Jiawen Geng 
Reviewed-By: Anna Henningsen

report: include network interfaces in report

2019-08-03T17:25:52+00:00

PR-URL: https://github.com/nodejs/node/pull/28911
Reviewed-By: Richard Lau 
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: fix OpenBSD build

2019-07-30T06:27:12+00:00

PR-URL: https://github.com/nodejs/node/pull/28384
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rich Trott

report: loop over uv_cpu_info() results

2019-07-26T04:43:29+00:00

The code currently loops over the results, but only the
first result is accessed.

PR-URL: https://github.com/nodejs/node/pull/28829
Reviewed-By: Richard Lau 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

src: correct json writer placement in process.report

2019-07-06T05:47:00+00:00

PR-URL: https://github.com/nodejs/node/pull/28433
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Ruben Bridgewater

report: add report versioning

2019-06-20T20:16:11+00:00

This commit adds a version to the diagnostic report feature.

PR-URL: https://github.com/nodejs/node/pull/28121
Reviewed-By: Anna Henningsen 
Reviewed-By: Gireesh Punathil

report: add cpu info to report output

2019-06-16T03:53:07+00:00

The report shows CPU consumption %, but without the number of CPU cores,
a consumer cannot tell if the percent (given across all cores) is
actually problematic. E.g., 100% on one CPU is a problem, but 100% on
four CPUs is not necessarily.

This change adds CPU information (similar to `os.cpus()`) to the report
output. Extra info besides the count is also provided as to avoid future
breaking changes in the eventuality that someone needs it; changing the
datatype of `header.cpus` would be breaking.

PR-URL: https://github.com/nodejs/node/pull/28188
Refs: https://github.com/nodejs/diagnostics/issues/307
Reviewed-By: Sam Roberts 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Richard Lau 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

src: move DiagnosticFilename inlines into a -inl.h

2019-05-26T15:09:45+00:00

DiagnosticFilename's constructor default values use inlines from
env-inl.h, causing the many users of node_internals.h to include
env-inl.h, even if they never use DiagnosticFilename.

PR-URL: https://github.com/nodejs/node/pull/27839
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: remove env-inl.h from header files

2019-05-23T15:51:41+00:00

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: extract common macro to util.h

2019-05-11T09:49:52+00:00

PR-URL: https://github.com/nodejs/node/pull/27512
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell