delta/node-new.git/src/node_process_object.cc, branch sam-github-tsc

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

src: retrieve binding data from the context

2020-05-06T04:44:04+00:00

Instead of passing them through the data bound to function
templates, store references to them in a list embedded inside
the context.
This makes the function templates more context-independent,
and makes it possible to embed binding data in non-main contexts.

Co-authored-by: Anna Henningsen 

PR-URL: https://github.com/nodejs/node/pull/33139
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: make creating per-binding data structures easier

2020-04-06T00:06:35+00:00

Enable the state associated with the individual bindings, e.g. fs or
http2, to be moved out of the Environment class, in order for these
to be more modular and for Environment to be come less of a collection
of random data fields.

Do this by using a BaseObject as the data for callbacks, which can hold
the per-binding state. By default, no per-binding state is available,
although that can be configured when setting up the binding.

PR-URL: https://github.com/nodejs/node/pull/32538
Reviewed-By: James M Snell

src: wrap HostPort in ExclusiveAccess

2020-02-13T19:53:36+00:00

I found it exceedingly hard to figure out if there is a race condition
where one thread reads the inspector agent's HostPort's properties while
another modifies them concurrently.

I think the answer is "no, there isn't" but with this commit use sites
are forced to unwrap the object (and acquire the mutex in the process),
making it a great deal easier to reason about correctness.

PR-URL: https://github.com/nodejs/node/pull/31717
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: David Carlier

src: fix OOB reads in process.title getter

2020-02-07T22:49:18+00:00

The getter passed a stack-allocated, fixed-size buffer to
uv_get_process_title() but neglected to check the return value.

When the total length of the command line arguments exceeds the size of
the buffer, libuv returns UV_ENOBUFS and doesn't modify the contents of
the buffer. The getter then proceeded to return whatever garbage was on
the stack at the time of the call, quite possibly reading beyond the
end of the buffer.

Add a GetProcessTitle() helper that reads the process title into a
dynamically allocated buffer that is resized when necessary.

Fixes: https://github.com/nodejs/node/issues/31631

PR-URL: https://github.com/nodejs/node/pull/31633
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott

src: persist strings that are used multiple times in the environment

2019-11-08T22:50:04+00:00

PR-URL: https://github.com/nodejs/node/pull/30321
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: David Carlier 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig

doc, lib, src, test, tools: fix assorted typos

2019-08-12T23:00:22+00:00

PR-URL: https://github.com/nodejs/node/pull/29075
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca

src: save exec path when initializing Environment

2019-06-19T03:25:24+00:00

PR-URL: https://github.com/nodejs/node/pull/28252
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: inline ProcessCliArgs in the Environment constructor

2019-06-03T15:27:48+00:00

Inline `ProcessCliArgs()` in the `Environment` constructor, and
emit the `Environment` creation trace events with the arguments
earlier. Remove the unused arguments passed to `CreateProcessObject()`
since these are now attached to process in `PatchProcessObject()`
during pre-execution instead.

PR-URL: https://github.com/nodejs/node/pull/27539
Reviewed-By: Anna Henningsen

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang