delta/node-new.git/src/node_process_methods.cc, branch devsnek-patch-1

src: remove duplicate logic for getting buffer

2020-11-13T21:50:49+00:00

We were fetching the buffer from the float array to send out the
response in js land, however that logic is being duplicated in
node_process.h. Now they will be using an inline to fetch the array
buffers and making it more generic.

PR-URL: https://github.com/nodejs/node/pull/34553
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

process: update v8 fast api calls usage

2020-10-18T18:18:00+00:00

This commit removes the WrapperTraits specialization for FastHrtime
according to recent changes in the V8 API.

Refs: https://github.com/nodejs/node/issues/33374

PR-URL: https://github.com/nodejs/node/pull/35415
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Matteo Collina 
Reviewed-By: Myles Borins

src: error reporting on CPUUsage

2020-10-16T22:45:47+00:00

Currently we are returning the stringified error code while in other
process methods we are throwin a UVException and only exclusion is in
the CPUUsage. Converted it to follow the convention.

PR-URL: https://github.com/nodejs/node/pull/34762
Reviewed-By: James M Snell 
Reviewed-By: David Carlier 
Reviewed-By: Mary Marchini 
Reviewed-By: Zeyu Yang 
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gireesh Punathil

src: move node_process to modern THROW_ERR*

2020-10-10T15:00:32+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/35472
Reviewed-By: Joyee Cheung

Revert "src: runtime deprecate process.umask()"

2020-10-01T01:46:25+00:00

This reverts commit 60c4c2b6c557efbb2f8f3a3de147baf987931d41.

PR-URL: https://github.com/nodejs/node/pull/35332
Reviewed-By: Colin Ihrig 
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Ruy Adorno

src: snapshot node

2020-07-18T03:23:21+00:00

This runs `lib/internal/bootstrap/node.js` before creating
the builtin snapshot and deserialize the loaders from the
snapshot in deserialization mode.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

bootstrap: build fast APIs in pre-execution

2020-07-18T03:23:18+00:00

Fast APIs need to work with ArrayBuffers which we need
to rebuild connections to after deserializing them
from the snapshot. For now, postpone their creation
until pre-execution to simplify the process.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

lib,src: remove cpu profiler idle notifier

2020-06-25T18:52:53+00:00

I added it in commit 57231d5286 ("src: notify V8 profiler when we're
idle") from October 2013 as a stop-gap measure to measure CPU time
rather than wall clock time, otherwise processes that spend a lot
of time sleeping in system calls give a false impression of being
very busy.

That fix is not without drawbacks because the idle flag is set before
libuv makes I/O callbacks and cleared again after. I/O callbacks can
result into calls into JS code and executing JS code is as non-idle
as you can get.

In commit 96ffcb9a21 ("src: reduce cpu profiler overhead") from January
2015, I made Node.js block off the SIGPROF signal that V8's CPU profiler
uses before Node.js goes to sleep. The goal of that commit is to reduce
the overhead from EINTR system call wakeups but it also has the pleasant
side effect of fixing what the idle notifier tried to fix.

This commit removes the idle notifier and turns the JS process object
methods into no-ops.

Fixes: https://github.com/nodejs/node/issues/19009
Refs: https://github.com/nodejs/node/pull/33138

PR-URL: https://github.com/nodejs/node/pull/34010
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: minor updates to FastHrtime

2020-06-19T15:35:36+00:00

- Don’t use 12 as a magic number for the buffer size
- Mark the object as weak (which is conceptually the right thing to do,
  even if there is little practical impact)
- Keep a reference to the `ArrayBuffer` in question for memory tracking

PR-URL: https://github.com/nodejs/node/pull/33851
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell

src: introduce BaseObject base FunctionTemplate

2020-06-14T12:53:38+00:00

PR-URL: https://github.com/nodejs/node/pull/33772
Reviewed-By: Benjamin Gruenbaum