delta/node-new.git/src/node_platform.h, branch devsnek-patch-1

src: implement NodePlatform::PostJob

2020-10-18T18:17:48+00:00

V8 is starting to use the job API for Wasm compilation, so the node
platform should implement that.

PR-URL: https://github.com/nodejs/node/pull/35415
Reviewed-By: Rich Trott 
Reviewed-By: Jiawen Geng 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Matteo Collina 
Reviewed-By: Myles Borins

src: add public APIs to manage v8::TracingController

2020-06-15T23:04:31+00:00

We added a hack for this a while ago for Electron, so let’s remove
that hack and make this an official API.

Refs: https://github.com/nodejs/node/pull/28724
Refs: https://github.com/nodejs/node/issues/33800

PR-URL: https://github.com/nodejs/node/pull/33850
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: shutdown platform from FreePlatform()

2020-03-21T09:58:19+00:00

There is currently no way to properly do this.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: allow non-Node.js TracingControllers

2020-03-21T09:57:40+00:00

We do not need a Node.js-provided `v8::TracingController`, generally.
Loosen that restriction in order to make it easier for embedders
to provide their own subclass of `v8::TracingController`,
or none at all.

Refs: https://github.com/electron/electron/commit/9c36576dddfaecde1298ff3e089d21a6e54fe67f

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: avoid Isolate::GetCurrent() for platform implementation

2020-03-21T00:50:35+00:00

There’s no need to use `Isolate::GetCurrent()`, which is generally
discouraged, as the `Isolate*` pointer can generally be looked up
from the per-Isolate platform data structure.

PR-URL: https://github.com/nodejs/node/pull/32269
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell

src: stop overriding deprecated V8 methods

2020-03-18T23:37:18+00:00

These methods will be removed in V8 8.1, hence we need to stop
overriding them.

PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso 
Reviewed-By: Jiawen Geng 
Reviewed-By: Ruben Bridgewater

src: enable stack trace printing for V8 check failures

2019-12-27T01:14:33+00:00

Example output:

    $ ./node --expose-gc test/addons/buffer-free-callback/test.js

    #
    # Fatal error in , line 0
    # Check failed: result.second.
    #
    #
    #
    #FailureMessage Object: 0x7ffebd956860
     1: 0x56290a45b105  [./node]
     2: 0x56290b305b77 V8_Fatal(char const*, ...) [./node]
     3: 0x56290a82702d v8::internal::GlobalBackingStoreRegistry::Register(std::shared_ptr) [./node]
     4: 0x56290a59a1de v8::ArrayBuffer::GetBackingStore() [./node]
     5: 0x56290a3cb63f node::Buffer::New(node::Environment*, char*, unsigned long, void (*)(char*, void*), void*) [./node]
     6: 0x56290a3cbcdc node::Buffer::New(v8::Isolate*, char*, unsigned long, void (*)(char*, void*), void*) [./node]
     7: 0x7fdeabdfdf89 Alloc(v8::FunctionCallbackInfo const&) [/home/xxxx/src/node/master/test/addons/buffer-free-callback/build/Release/binding.node]
     8: 0x56290a5ca077  [./node]
     9: 0x56290a5cbf97 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [./node]
    10: 0x56290ad99539  [./node]
    Illegal instruction (core dumped)

PR-URL: https://github.com/nodejs/node/pull/31079
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell

src: add abstract `IsolatePlatformDelegate`

2019-11-20T18:02:55+00:00

Adds a new abstract class for module authors and embedders to register
arbitrary isolates with `node::MultiIsolatePlatform`.

PR-URL: https://github.com/nodejs/node/pull/30324
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung

src: make implementing CancelPendingDelayedTasks for platform optional

2019-10-22T18:51:45+00:00

Fold `CancelPendingDelayedTasks()` into `UnregisterIsolate()` and
make implementing it optional.

It makes sense for these two operations to happen at the same time,
so it is sufficient to provide a single operation instead of two
separate ones.

PR-URL: https://github.com/nodejs/node/pull/30034
Reviewed-By: Ben Noordhuis 
Reviewed-By: Shelley Vohr

src: unimplement deprecated v8-platform methods

2019-05-30T13:51:37+00:00

This removes the implementations of NodePlatform::CallOnForegroundThread
and NodePlatform::CallDelayedOnForegroundThread and updates the
test_platform cctest to stop using them.

PR-URL: https://github.com/nodejs/node/pull/27872
Reviewed-By: Gus Caplan 
Reviewed-By: Refael Ackermann 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig