delta/node-new.git/src/node_platform.cc, branch docs-fix

src: add public APIs to manage v8::TracingController

2020-06-15T23:04:31+00:00

We added a hack for this a while ago for Electron, so let’s remove
that hack and make this an official API.

Refs: https://github.com/nodejs/node/pull/28724
Refs: https://github.com/nodejs/node/issues/33800

PR-URL: https://github.com/nodejs/node/pull/33850
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: prefer make_unique

2020-05-20T13:17:57+00:00

In most of the code base we use make_unique instead of
new unique_ptr. Update node_platform.cc to be consistent
with that.

Signed-off-by: Michael Dawson 

PR-URL: https://github.com/nodejs/node/pull/33378
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Zeyu Yang 
Reviewed-By: Juan José Arboleda

src: remove unused CancelPendingDelayedTasks

2020-04-24T14:14:48+00:00

PR-URL: https://github.com/nodejs/node/pull/32859
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Franziska Hinkelmann

src: shutdown platform from FreePlatform()

2020-03-21T09:58:19+00:00

There is currently no way to properly do this.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: allow non-Node.js TracingControllers

2020-03-21T09:57:40+00:00

We do not need a Node.js-provided `v8::TracingController`, generally.
Loosen that restriction in order to make it easier for embedders
to provide their own subclass of `v8::TracingController`,
or none at all.

Refs: https://github.com/electron/electron/commit/9c36576dddfaecde1298ff3e089d21a6e54fe67f

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: make `FreeEnvironment()` perform all necessary cleanup

2020-03-21T09:57:08+00:00

Make the calls `stop_sub_worker_contexts()`, `RunCleanup()`
part of the public API for easier embedding.

(Note that calling `RunAtExit()` is idempotent because the
at-exit callback queue is cleared after each call.)

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: avoid Isolate::GetCurrent() for platform implementation

2020-03-21T00:50:35+00:00

There’s no need to use `Isolate::GetCurrent()`, which is generally
discouraged, as the `Isolate*` pointer can generally be looked up
from the per-Isolate platform data structure.

PR-URL: https://github.com/nodejs/node/pull/32269
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell

src: discard tasks posted to platform TaskRunner during shutdown

2020-03-11T15:38:56+00:00

Discard tasks silently that are posted when the Isolate is being
disposed.

It is not possible to avoid a race condition window between
unregistering the Isolate with the platform and disposing it
in which background tasks and the Isolate deinit steps themselves
may lead to new tasks being posted. The only sensible action
in that case is discarding the tasks.

Fixes: https://github.com/nodejs/node/issues/31752
Fixes: https://bugs.chromium.org/p/v8/issues/detail?id=10104
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2061548
Refs: https://github.com/nodejs/node/pull/31795
Refs: https://github.com/nodejs/node/pull/30909
PR-URL: https://github.com/nodejs/node/pull/31853
Reviewed-By: Joyee Cheung

async_hooks: add executionAsyncResource

2020-02-11T19:59:09+00:00

Remove the need for the destroy hook in the basic APM case.

Co-authored-by: Stephen Belanger 
PR-URL: https://github.com/nodejs/node/pull/30959
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell

src: add C++-style sprintf utility

2020-01-23T21:38:58+00:00

Add an utility that handles C++-style strings and objects well.

PR-URL: https://github.com/nodejs/node/pull/31446
Fixes: https://github.com/nodejs/node/issues/28761
Fixes: https://github.com/nodejs/node/issues/31218
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott