delta/node-new.git/src/node_platform.cc, branch crypto_set_integer_macro

src: reduce platform worker barrier lifetime

2018-10-13T05:30:53+00:00

Minor cleanup in the lifetime for the platform worker initialization
synchronization barrier.

PR-URL: https://github.com/nodejs/node/pull/23419
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko 
Reviewed-By: Colin Ihrig

src: trace_event: secondary storage for metadata

2018-10-12T21:12:31+00:00

Metadata trace-events should be held in secondary storage so that they
can be periodically reemitted. This change establishes the secondary
storage and ensures that events are reemitted on each flush.

PR-URL: https://github.com/nodejs/node/pull/20900
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

trace_events: destroy platform before tracing

2018-10-06T13:05:17+00:00

For safer shutdown, we should destroy the platform – and background
threads - before the tracing infrastructure is destroyed. This change
fixes the relative order of NodePlatform disposition and the tracing
agent shutting down. This matches the nesting order for startup.

Make the tracing agent own the tracing controller instead of platform
to match the above.

Fixes: https://github.com/nodejs/node/issues/22865

PR-URL: https://github.com/nodejs/node/pull/22938
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina

src: ready background workers before bootstrap

2018-10-06T04:31:09+00:00

Make sure background workers are ready before proceeding with the
bootstrap or post-bootstrap execution of any code that may trigger
`process.exit()`.

Fixes: https://github.com/nodejs/node/issues/23065

PR-URL: https://github.com/nodejs/node/pull/23233
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: initialize PerIsolateData eagerly

2018-09-07T19:07:25+00:00

PR-URL: https://github.com/nodejs/node/pull/21983
Reviewed-By: Refael Ackermann 
Reviewed-By: Gus Caplan 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Matteo Collina

src: implement v8::Platform::CallDelayedOnWorkerThread

2018-08-21T01:10:00+00:00

This method is crucial for Runtime.evaluate protocol command with
timeout flag. At least Chrome DevTools frontend uses this method for
every execution in console.

PR-URL: https://github.com/nodejs/node/pull/22383
Fixes: https://github.com/nodejs/node/issues/22157
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: rename WorkerThreadMain to PlatformWorkerThread

2018-07-29T19:41:28+00:00

Refs: https://github.com/nodejs/node/pull/21079#discussion_r194251183

PR-URL: https://github.com/nodejs/node/pull/21982
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

src: use modern v8::Platform worker threads APIs

2018-07-26T06:35:06+00:00

Precursor to removing deprecated APIs on the v8 side @
https://chromium-review.googlesource.com/c/v8/v8/+/1045310

PR-URL: https://github.com/nodejs/node/pull/21079
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: Yang Guo

src: remove .h if -inl.h is already included

2018-06-20T03:42:39+00:00

This commit removes the normal header file include if an internal one
is specified as per the CPP_STYLE_GUIDE.

PR-URL: https://github.com/nodejs/node/pull/21381
Reviewed-By: Matheus Marchini 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ujjwal Sharma

src: add consistency check to node_platform.cc

2018-06-07T23:16:03+00:00

We use the `Isolate*` pointer as the sole identifier
for a V8 Isolate. In some environments (e.g. multi-threaded),
Isolates may be destroyed and new ones created; then, it
may happen that the memory that was previously used for
one `Isolate` can be re-used for another `Isolate`
after the first one has been disposed of.

This check is a little guard against accidentally
re-using the same per-Isolate platform data structure
in such cases, i.e. making sure (to the degree to which
that is possible) that the old `Isolate*` has been properly
unregistered before one at the same memory address is added.

(It’s not 100 % foolproof because the `uv_loop_t*`
pointer value could theoretically be the same as well.)

PR-URL: https://github.com/nodejs/node/pull/21156
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig