delta/node-new.git/src/node_os.cc, branch sam-github-tsc

src: use ToLocal in node_os.cc

2020-06-25T01:00:51+00:00

PR-URL: https://github.com/nodejs/node/pull/33939
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use using NewStringType

2020-04-23T16:11:02+00:00

PR-URL: https://github.com/nodejs/node/pull/32843
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Franziska Hinkelmann

src: remove validation of unreachable code

2020-04-19T14:24:09+00:00

Based on https://github.com/nodejs/help/issues/2600#issuecomment-612857153
the condition (amount < 0) won't be possible.

PR-URL: https://github.com/nodejs/node/pull/32818
Reviewed-By: Anna Henningsen 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Zeyu Yang 
Reviewed-By: Shelley Vohr 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: create a getter for kernel version

2020-03-09T11:44:16+00:00

PR-URL: https://github.com/nodejs/node/pull/31732
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: migrate off ArrayBuffer::GetContents

2019-11-12T05:29:23+00:00

V8 deprecates `GetContents()` in favour of `GetBackingStore()`.
Update our code to reflect that.
V8 also deprecates `Externalize()` and `IsExternal()`; we should
be able to remove all usage of this once V8 8.0 is there.

PR-URL: https://github.com/nodejs/node/pull/30339
Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34
Reviewed-By: Gus Caplan 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Jiawen Geng 
Reviewed-By: David Carlier

src: do not use `std::function` for `OnScopeLeave`

2019-11-07T09:39:40+00:00

Using `std::function` adds an extra layer of indirection, and in
particular, heap allocations that are not necessary in our use case
here.

PR-URL: https://github.com/nodejs/node/pull/30134
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell

os: assume UTF-8 for hostname

2019-05-26T13:38:51+00:00

Do not assume Latin-1, but rather UTF-8 for the result of getting the
OS hostname.

While in 99 % of cases these strings are stored in ASCII, the OS does
not enforce an encoding on its own, and apparently the hostname is
sometimes set to non-ASCII data (despite at least some versions of
hostname(1) rejecting such input, making it even harder to write a
test for this which would already require root privileges).

In any case, these are short strings, so assuming UTF-8 comes
with no significant overhead.

Fixes: https://github.com/nodejs/node/issues/27848

PR-URL: https://github.com/nodejs/node/pull/27849
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sam Roberts 
Reviewed-By: James M Snell 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
Reviewed-By: Yongsheng Zhang

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: de-lint header usage

2019-03-12T13:57:19+00:00

PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil