delta/node-new.git/src/node_os.cc, branch Ninja.py-StringIO

os: assume UTF-8 for hostname

2019-05-26T13:38:51+00:00

Do not assume Latin-1, but rather UTF-8 for the result of getting the
OS hostname.

While in 99 % of cases these strings are stored in ASCII, the OS does
not enforce an encoding on its own, and apparently the hostname is
sometimes set to non-ASCII data (despite at least some versions of
hostname(1) rejecting such input, making it even harder to write a
test for this which would already require root privileges).

In any case, these are short strings, so assuming UTF-8 comes
with no significant overhead.

Fixes: https://github.com/nodejs/node/issues/27848

PR-URL: https://github.com/nodejs/node/pull/27849
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sam Roberts 
Reviewed-By: James M Snell 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
Reviewed-By: Yongsheng Zhang

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: de-lint header usage

2019-03-12T13:57:19+00:00

PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: simplify loop arithmetic in `GetCPUInfo`

2019-02-21T07:45:40+00:00

Cache the repeated operations and reuse; potentially generating
efficient code in some platforms, and improving readability.

PR-URL: https://github.com/nodejs/node/pull/26183
Reviewed-By: Richard Lau 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell

os,report: use UV_MAXHOSTNAMESIZE

2019-02-13T13:19:41+00:00

UV_MAXHOSTNAMESIZE was introduced in libuv 1.26.0. Use this
instead of including multiple header files, adding fallback
ifdef logic, and remembering to add one to the buffer size
for the terminating nul character with MAXHOSTNAMELEN.

PR-URL: https://github.com/nodejs/node/pull/26038
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Richard Lau 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

os: implement os.type() using uv_os_uname()

2019-01-25T13:54:55+00:00

The happy path behavior should be identical on all
platforms except MinGW, which now identifies MinGW
separately from Windows.

PR-URL: https://github.com/nodejs/node/pull/25659
Reviewed-By: Bartosz Sosnowski 
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Jeremiah Senkpiel

src: remove using v8::Function in node_os.cc

2019-01-24T13:30:19+00:00

PR-URL: https://github.com/nodejs/node/pull/25640
Reviewed-By: Denys Otrishko 
Reviewed-By: Michael Dawson 
Reviewed-By: Richard Lau 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tiancheng "Timothy" Gu

os: implement os.release() using uv_os_uname()

2019-01-23T05:15:10+00:00

For non-Windows platforms, the happy path behavior should be
identical. On Windows, uv_os_uname() attempts to use
RtlGetVersion() before falling back to the deprecated
GetVersionExW() that Node was previously using.

PR-URL: https://github.com/nodejs/node/pull/25600
Reviewed-By: Bartosz Sosnowski 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis