delta/node-new.git/src/node_options.h, branch crypto_set_integer_macro

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

src: add virtual desctructor to Options class

2018-10-05T03:11:08+00:00

Currently the Options class has a virtual function but no virtual
destructor which means that if delete is called on a Options pointer
to a derived instance, the derived destructor will not get called.

The following warning is currently being printed when
compiling:

warning: delete called on non-final 'node::PerIsolateOptions' that has
virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
    delete __ptr;

This commit adds a virtual destructor.

PR-URL: https://github.com/nodejs/node/pull/23215
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: fix a typo in the comment

2018-09-25T17:04:15+00:00

withing -> within

PR-URL: https://github.com/nodejs/node/pull/23078
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

src: add CheckOptions to Options classes

2018-09-22T10:00:28+00:00

This commit adds a CheckOptions function that the options classes can
optionally implement to check that options specified are correct
(dependencies between options are met or options that are mutually
exclusive).

In the process of doing this the error pointer passed to Parse was
changed to be of type vector so that potentially multiple options check
failures can be reported.

PR-URL: https://github.com/nodejs/node/pull/22943
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

tools: add bash completion for node

2018-09-21T05:18:24+00:00

This commit adds a --completion-bash option to node which can be
sourced to provide bash code completion for node options.

Usage:
$ node --completion-bash  > node_bash_completion
$ source node_bash_completion
$ node --[tab]

PR-URL: https://github.com/nodejs/node/pull/20713
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

src: remove abort_on_uncaught_exception node.cc

2018-09-09T11:39:03+00:00

This commit removes the static variable abort_on_uncaught_exception and
adds it to the environment options.

PR-URL: https://github.com/nodejs/node/pull/22724
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: make CLI options programatically accesible

2018-08-31T22:13:20+00:00

Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.

PR-URL: https://github.com/nodejs/node/pull/22490
Reviewed-By: Michaël Zasso

src: refactor options parsing

2018-08-22T21:37:19+00:00

This is a major refactor of our Node’s parser. See `node_options.cc`
for how it is used, and  `node_options-inl.h` for the bulk
of its implementation.

Unfortunately, the implementation has come to have some
complexity, in order to meet the following goals:

- Make it easy to *use* for defining or changing options.
- Keep it (mostly) backwards-compatible.
  - No tests were harmed as part of this commit.
- Be as consistent as possible.
  - In particular, options can now generally accept arguments
    through both `--foo=bar` notation and `--foo bar` notation.
    We were previously very inconsistent on this point.
- Separate into different levels of scope, namely
  per-process (global), per-Isolate and per-Environment
  (+ debug options).
- Allow programmatic accessibility in the future.
  - This includes a possible expansion for `--help` output.

This commit also leaves a number of `TODO` comments, mostly for
improving consistency even more (possibly with having to modify
tests), improving embedder support, as well as removing pieces of
exposed configuration variables that should never have become
part of the public API but unfortunately are at this point.

PR-URL: https://github.com/nodejs/node/pull/22392
Reviewed-By: Matteo Collina 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

Revert "src: add getopt option parser"

2015-06-01T16:25:32+00:00

This reverts commit c0e7bf2d8ceb65ad3840bc4ebf3cbd9fef8e8c14.

There are a few edge cases that can cause a crash
and need to be properly handled.

PR-URL: https://github.com/nodejs/io.js/pull/1862
Reviewed-By: Ben Noordhuis

src: add getopt option parser

2015-06-01T13:39:06+00:00

Options have been moved into the NodeOptions class.
A new global, node_options now exists and is used
to access the options after the command line arguments
have been parsed.

PR-URL: https://github.com/nodejs/io.js/pull/1804
Reviewed-By: Ben Noordhuis