delta/node-new.git/src/node_options.cc, branch ofrobots-patch-1

cli: normalize `_` → `-` when parsing options

2018-09-25T11:32:30+00:00

This allows for option syntax similar to V8’s one, e.g.
`--no_warnings` has the same effect as `--no-warnings`.

PR-URL: https://github.com/nodejs/node/pull/23020
Reviewed-By: Michaël Zasso 
Reviewed-By: Gus Caplan 
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Trivikram Kamat

src: add CheckOptions to Options classes

2018-09-22T10:00:28+00:00

This commit adds a CheckOptions function that the options classes can
optionally implement to check that options specified are correct
(dependencies between options are met or options that are mutually
exclusive).

In the process of doing this the error pointer passed to Parse was
changed to be of type vector so that potentially multiple options check
failures can be reported.

PR-URL: https://github.com/nodejs/node/pull/22943
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

tools: add bash completion for node

2018-09-21T05:18:24+00:00

This commit adds a --completion-bash option to node which can be
sourced to provide bash code completion for node options.

Usage:
$ node --completion-bash  > node_bash_completion
$ source node_bash_completion
$ node --[tab]

PR-URL: https://github.com/nodejs/node/pull/20713
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

src: fix `--prof-process` CLI argument handling

2018-09-16T07:44:37+00:00

Make sure that options after `--prof-process` are not treated
as Node.js options.

Fixes: https://github.com/nodejs/node/issues/22786

PR-URL: https://github.com/nodejs/node/pull/22790
Reviewed-By: Joyee Cheung 
Reviewed-By: Matteo Collina 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Bryan English 
Reviewed-By: Trivikram Kamat

src: fix trace-event-file-pattern description

2018-09-07T09:09:03+00:00

PR-URL: https://github.com/nodejs/node/pull/22690
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Richard Lau

src: remove editing leftovers from options help text

2018-09-05T05:36:44+00:00

PR-URL: https://github.com/nodejs/node/pull/22636
Refs: https://github.com/nodejs/node/commit/
85212bb182f555f6d09e0b2f5f78d2d8e19bcef1#r30265305
Reviewed-By: Richard Lau 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

src: disable debug options when inspector is unavailable

2018-09-02T23:39:20+00:00

This fixes `parallel/test-cli-node-print-help` when Node.js
is compiled without the inspector.

PR-URL: https://github.com/nodejs/node/pull/22657
Reviewed-By: Gireesh Punathil 
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Refael Ackermann 
Reviewed-By: Denys Otrishko

cli: generate --help text in JS

2018-08-31T22:13:23+00:00

Instead of having a custom, static, hand-written string
that is being printed to stdout when `--help` is present,
generate it in JS when requested.

PR-URL: https://github.com/nodejs/node/pull/22490
Reviewed-By: Michaël Zasso

src: make CLI options programatically accesible

2018-08-31T22:13:20+00:00

Provide `internalBinding('options')` with some utilities
around making the options parser and current options values
programatically accessible.

PR-URL: https://github.com/nodejs/node/pull/22490
Reviewed-By: Michaël Zasso

src: refactor options parsing

2018-08-22T21:37:19+00:00

This is a major refactor of our Node’s parser. See `node_options.cc`
for how it is used, and  `node_options-inl.h` for the bulk
of its implementation.

Unfortunately, the implementation has come to have some
complexity, in order to meet the following goals:

- Make it easy to *use* for defining or changing options.
- Keep it (mostly) backwards-compatible.
  - No tests were harmed as part of this commit.
- Be as consistent as possible.
  - In particular, options can now generally accept arguments
    through both `--foo=bar` notation and `--foo bar` notation.
    We were previously very inconsistent on this point.
- Separate into different levels of scope, namely
  per-process (global), per-Isolate and per-Environment
  (+ debug options).
- Allow programmatic accessibility in the future.
  - This includes a possible expansion for `--help` output.

This commit also leaves a number of `TODO` comments, mostly for
improving consistency even more (possibly with having to modify
tests), improving embedder support, as well as removing pieces of
exposed configuration variables that should never have become
part of the public API but unfortunately are at this point.

PR-URL: https://github.com/nodejs/node/pull/22392
Reviewed-By: Matteo Collina 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan