delta/node-new.git/src/node_messaging.h, branch Ninja.py-StringIO

worker: make MessagePort constructor non-callable

2019-06-13T03:56:44+00:00

Refactor the C++ code for creating `MessagePort`s to skip calling the
constructor and instead directly instantiating the `InstanceTemplate`,
and always throw an error from the `MessagePort` constructor.

This aligns behaviour with the web, and creating single `MessagePort`s
does not make sense anyway.

PR-URL: https://github.com/nodejs/node/pull/28032
Reviewed-By: Rich Trott 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell

worker: add ability to unshift message from MessagePort

2019-05-19T20:01:34+00:00

In combination with Atomics, this makes it possible to implement
generic synchronous functionality, e.g. `importScript()`, in Workers
purely by communicating with other threads.

This is a continuation of https://github.com/nodejs/node/pull/26686,
where a preference for a solution was voiced that allowed reading
individual messages, rather than emitting all messages through events.

PR-URL: https://github.com/nodejs/node/pull/27294
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater

worker: use special message as MessagePort close command

2019-05-17T12:01:27+00:00

When a `MessagePort` connected to another `MessagePort` closes, the
latter `MessagePort` will be closed as well. Until now, this is done
by testing whether the ports are still entangled after processing
messages. This leaves open a race condition window in which messages
sent just before the closure can be lost when timing is unfortunate.
(A description of the timing is in the test file.)

This can be addressed by using a special message instead, which is
the last message received by a `MessagePort`. This way, all previously
sent messages are processed first.

Fixes: https://github.com/nodejs/node/issues/22762
PR-URL: https://github.com/nodejs/node/pull/27705
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

worker: move `receiving_messages_` field to `MessagePort`

2019-05-17T12:01:23+00:00

This is a property of the native object associated with the
`MessagePort`, not something that should be set on the
conceptual `MessagePort` that may be transferred around.

PR-URL: https://github.com/nodejs/node/pull/27705
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

worker: implement worker.moveMessagePortToContext()

2019-03-15T15:54:19+00:00

This enables using `MessagePort`s in different `vm.Context`s,
aiding with the isolation that the `vm` module seeks to provide.

Refs: https://github.com/ayojs/ayo/pull/111

PR-URL: https://github.com/nodejs/node/pull/26497
Reviewed-By: James M Snell

src: fix warning in node_messaging

2019-03-15T15:01:02+00:00

PR-URL: https://github.com/nodejs/node/pull/26682
Reviewed-By: Anna Henningsen 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell

worker: make MessagePort `uv_async_t` inline field

2019-03-01T20:44:05+00:00

It’s not obvious why this was a heap allocation in the first place,
but it’s unneccessary. Most other `HandleWrap`s also store the
libuv handle directly.

PR-URL: https://github.com/nodejs/node/pull/26271
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gireesh Punathil

worker: remove MessagePort::AddToIncomingQueue

2019-03-01T20:44:04+00:00

PR-URL: https://github.com/nodejs/node/pull/26271
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gireesh Punathil

worker: refactor thread life cycle management

2019-03-01T09:14:55+00:00

The current mechanism of uses two async handles, one owned by the
creator of the worker thread to terminate a running worker,
and another one employed by the worker to interrupt its creator on its
natural termination. The force termination piggybacks on the message-
passing mechanism to inform the worker to quiesce.

Also there are few flags that represent the other thread's state /
request state because certain code path is shared by multiple
control flows, and there are certain code path where the async
handles may not have come to life.

Refactor into an AsyncRequest abstraction that exposes routines to
install a handle as well as to save a state.

PR-URL: https://github.com/nodejs/node/pull/26099
Refs: https://github.com/nodejs/node/pull/21283
Reviewed-By: Anna Henningsen

src: apply clang-tidy rule performance-unnecessary-value-param

2019-02-19T11:54:41+00:00

PR-URL: https://github.com/nodejs/node/pull/26042
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell