delta/node-new.git/src/node_messaging.cc, branch crypto_set_integer_macro

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

worker: hide MessagePort init function behind symbol

2018-09-25T22:32:12+00:00

This reduces unintended exposure of internals.

PR-URL: https://github.com/nodejs/node/pull/23037
Reviewed-By: Gus Caplan 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

src: simplify `MessagePort` construction code a bit

2018-09-25T22:27:35+00:00

Using `ASSIGN_OR_RETURN_UNWRAP` would return if the
created `MessagePort` object had no internal fields.
That would be a bug, so switch to a checked conversion instead.

PR-URL: https://github.com/nodejs/node/pull/23036
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung

src: enable more detailed memory tracking

2018-07-13T17:53:15+00:00

This will enable more detailed heap snapshots based on
a newer V8 API.

This commit itself is not tied to that API and could
be backported.

PR-URL: https://github.com/nodejs/node/pull/21742
Reviewed-By: James M Snell

src: add HandleWrap::AddWrapMethods

2018-07-13T16:08:20+00:00

Extracts common setters to a single location

PR-URL: https://github.com/nodejs/node/pull/21769
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

messaging: fix edge cases with transferring ports

2018-07-04T02:54:03+00:00

Currently, transferring the port on which postMessage is called causes a
segmentation fault, and transferring the target port causes a subsequent
port.onmessage setting to throw, or a deadlock if onmessage is set
before the postMessage. Fix both of these behaviors and align the
methods more closely with the normative definitions in the HTML
Standard.

Also, per spec postMessage must not throw just because the ports are
disentangled. Implement that behavior.

PR-URL: https://github.com/nodejs/node/pull/21540
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

messaging: use actual DOMException for DataCloneError

2018-07-04T02:53:59+00:00

PR-URL: https://github.com/nodejs/node/pull/21540
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: add native debugging code to workers

2018-06-25T06:04:55+00:00

Now that we have better native debugging utilities in core,
let’s use them :)

PR-URL: https://github.com/nodejs/node/pull/21423
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Matheus Marchini