delta/node-new.git/src/node_main_instance.cc, branch sam-github-tsc

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

src: remove unused IsolateSettings variable

2020-05-18T05:13:45+00:00

PR-URL: https://github.com/nodejs/node/pull/33417
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove unused misc variable

2020-05-18T05:13:33+00:00

This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: https://github.com/nodejs/node/pull/33417
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: align worker and main thread code with embedder API

2020-03-21T09:57:20+00:00

This addresses some long-standing TODOs by Joyee and me about
making the embedder API more powerful and us less reliant on
internal APIs for creating the main thread and Workers.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: associate is_main_thread() with worker_context()

2020-03-21T09:57:17+00:00

In our codebase, the assumption generally is that `!is_main_thread()`
means that the current Environment belongs to a Node.js Worker thread.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: make `FreeEnvironment()` perform all necessary cleanup

2020-03-21T09:57:08+00:00

Make the calls `stop_sub_worker_contexts()`, `RunCleanup()`
part of the public API for easier embedding.

(Note that calling `RunAtExit()` is idempotent because the
at-exit callback queue is cleared after each call.)

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

Revert "src: keep main-thread Isolate attached to platform during Dispose"

2020-03-11T15:39:01+00:00

This reverts commit e460f8cf43863a5a8d73273ce311135ad3245699.

It is no longer necessary after the previous commit, and restores
consistency of the call order between the main thread code,
the other call sites, and the documentation.

Refs: https://github.com/nodejs/node/pull/31795
PR-URL: https://github.com/nodejs/node/pull/31853
Reviewed-By: Joyee Cheung

src: move InternalCallbackScope to StartExecution

2020-02-27T16:04:40+00:00

PR-URL: https://github.com/nodejs/node/pull/31944
Reviewed-By: Anna Henningsen 
Reviewed-By: Stephen Belanger 
Reviewed-By: Joyee Cheung

src: keep main-thread Isolate attached to platform during Dispose

2020-02-14T16:15:18+00:00

This works around a situation in which the V8 WASM code calls
into the platform while the Isolate is being disposed.

This goes against the V8 API constract for `v8::Platform`.
In lieu of a proper fix, it should be okay to keep the Isolate
registered; the race condition fixed by 25447d82d cannot
occur for the `NodeMainInstance`’s Isolate, as it is the last
one to exit in any given Node.js process.

This partially reverts 25447d82d.

Refs: https://github.com/nodejs/node/pull/30909
Refs: https://github.com/nodejs/node/issues/31752

PR-URL: https://github.com/nodejs/node/pull/31795
Reviewed-By: Denys Otrishko 
Reviewed-By: James M Snell

async_hooks: add executionAsyncResource

2020-02-11T19:59:09+00:00

Remove the need for the destroy hook in the basic APM case.

Co-authored-by: Stephen Belanger 
PR-URL: https://github.com/nodejs/node/pull/30959
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell