delta/node-new.git/src/node_main_instance.cc, branch docs-fix

src: snapshot node

2020-07-18T03:23:21+00:00

This runs `lib/internal/bootstrap/node.js` before creating
the builtin snapshot and deserialize the loaders from the
snapshot in deserialization mode.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

src: snapshot loaders

2020-07-18T03:23:15+00:00

This runs `lib/internal/bootstrap/loaders.js` before creating
the builtin snapshot and deserialize the loaders from the
snapshot in deserialization mode.

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

src: snapshot Environment upon instantiation

2020-07-18T03:15:57+00:00

This includes the initial Environment (without running bootstrap
scripts) into the builtin snapshot

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

src: add an ExternalReferenceRegistry class

2020-07-18T03:02:58+00:00

Add an ExternalReferenceRegistry class for registering static
external references.

To register the external JS to C++ references created in a binding
(e.g. when a FunctionTemplate is created):

- Add the binding name (same as the id used for `internalBinding()`
  and `NODE_MODULE_CONTEXT_AWARE_INTERNAL`) to
  `EXTERNAL_REFERENCE_BINDING_LIST` in `src/node_external_reference.h`.
- In the file where the binding is implemented, create a registration
  function to register the static C++ references (e.g. the C++
  functions in `v8::FunctionCallback` associated with the function
  templates), like this:

  ```c++
  void RegisterExternalReferences(
          ExternalReferenceRegistry* registry) {
    registry->Register(cpp_func_1);
  }
  ```
- At the end of the file where `NODE_MODULE_CONTEXT_AWARE_INTERNAL` is
  also usually called, register the registration function with

  ```
  NODE_MODULE_EXTERNAL_REFERENCE(binding_name,
                                 RegisterExternalReferences);
  ```

PR-URL: https://github.com/nodejs/node/pull/32984
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

src: remove unused IsolateSettings variable

2020-05-18T05:13:45+00:00

PR-URL: https://github.com/nodejs/node/pull/33417
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove unused misc variable

2020-05-18T05:13:33+00:00

This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: https://github.com/nodejs/node/pull/33417
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: align worker and main thread code with embedder API

2020-03-21T09:57:20+00:00

This addresses some long-standing TODOs by Joyee and me about
making the embedder API more powerful and us less reliant on
internal APIs for creating the main thread and Workers.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: associate is_main_thread() with worker_context()

2020-03-21T09:57:17+00:00

In our codebase, the assumption generally is that `!is_main_thread()`
means that the current Environment belongs to a Node.js Worker thread.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: make `FreeEnvironment()` perform all necessary cleanup

2020-03-21T09:57:08+00:00

Make the calls `stop_sub_worker_contexts()`, `RunCleanup()`
part of the public API for easier embedding.

(Note that calling `RunAtExit()` is idempotent because the
at-exit callback queue is cleared after each call.)

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil