delta/node-new.git/src/node_main.cc, branch devsnek-patch-1

src: use getauxval in node_main.cc

2020-06-05T03:52:24+00:00

This commit suggests using getauxval in node_main.cc.

The motivation for this is that getauxval was introduced in glibc 2.16
and looking at BUILDING.md, in the 'Platform list' section, it looks
like we now support glibc >= 2.17 and perhaps this change would be
alright now.

PR-URL: https://github.com/nodejs/node/pull/33693
Refs: https://github.com/nodejs/node/pull/12548
Reviewed-By: Ben Noordhuis 
Reviewed-By: David Carlier 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

win: allow skipping the supported platform check

2020-05-30T01:54:27+00:00

Fixes: https://github.com/nodejs/node/issues/33034

PR-URL: https://github.com/nodejs/node/pull/33176
Reviewed-By: Bartosz Sosnowski 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Ruben Bridgewater

win: block running on EOL Windows versions

2020-03-05T03:06:17+00:00

Windows 7 and Windows Server 2008 R2 EOL was January 14, 2020.
Windows 8 EOL was January 12, 2016.

Windows 2012 (not R2) is still supported and allowed to run. This
clarifies that support is experimental.

PR-URL: https://github.com/nodejs/node/pull/31954
Reviewed-By: Rod Vagg 
Reviewed-By: Rich Trott 
Reviewed-By: David Carlier 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

process: move POSIX credential accessors into node_credentials.cc

2018-12-18T18:44:03+00:00

Expose the POSIX credential accessors through
`internalBinding('credentials')` instead of setting them on the
process or bootstrapper object from C++ directly. Also moves
`SafeGetEnv` from `internalBinding('util')` to
`internalBinding('credentials')` since it's closely related to
the credentials.

In the JS land, instead of wrapping the bindings then writing
to the process object directly in main_thread_only.js, return
the wrapped functions back to bootstrap/node.js where they get
written to the process object conditionally for clarity.

Refs: https://github.com/nodejs/node/issues/24961

PR-URL: https://github.com/nodejs/node/pull/25066
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src, tools: add check for left leaning pointers

2018-06-07T03:46:51+00:00

This commit adds a rule to cpplint to check that pointers in the code
base lean to the left and not right, and also fixes the violations
reported.

PR-URL: https://github.com/nodejs/node/pull/21010
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

test: shared lib build doesn't handle SIGPIPE

2018-03-12T23:56:04+00:00

For shared lib build, we leave the signal handling for embedding users.
In these two test cases:
- `parallel/test-process-external-stdio-close-spawn`
- `parallel/test-process-external-stdio-close`

The pipe is used for stdout and is destroied before child process uses
it for logging. So the node executble that uses shared lib build
receives SIGPIPE and the child process ends.

This change ignores the SIGPIPE in node_main.cc for shared lib case.

Refs: https://github.com/nodejs/node/issues/18535

Signed-off-by: Yihong Wang 

PR-URL: https://github.com/nodejs/node/pull/19211
Refs: https://github.com/nodejs/node/issues/18535
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Gireesh Punathil

src: remove duplicate words in comments

2018-01-01T23:31:03+00:00

PR-URL: https://github.com/nodejs/node/pull/17939
Reviewed-By: Colin Ihrig 
Reviewed-By: Jon Moss 
Reviewed-By: James M Snell

src: refactor `#include` handling

2017-09-14T15:38:38+00:00

`node_internals.h` already includes the most common headers,
so double includes can be avoided in a lot of cases. Also don’t include
`node_internals.h` from `node.h` implicitly anymore, as that is mostly
unnecessary.

PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

src: add linux getauxval(AT_SECURE) in SafeGetenv

2017-05-25T17:05:14+00:00

This commit attempts to fix the following TODO:
// TODO(bnoordhuis) Should perhaps also check whether
getauxval(AT_SECURE) is non-zero on Linux.

This can be manually tested at the moment using the following steps:

$ setcap cap_net_raw+ep out/Release/node
$ NODE_PENDING_DEPRECATION="1" out/Release/node -p
"process.binding('config').pendingDeprecation"
true
$ useradd test
$ su test
$ NODE_PENDING_DEPRECATION="1" out/Release/node -p
"process.binding('config').pendingDeprecation"
undefined

PR-URL: https://github.com/nodejs/node/pull/12548
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis