delta/node-new.git/src/node_internals.h, branch docs-fix

lib,src: remove cpu profiler idle notifier

2020-06-25T18:52:53+00:00

I added it in commit 57231d5286 ("src: notify V8 profiler when we're
idle") from October 2013 as a stop-gap measure to measure CPU time
rather than wall clock time, otherwise processes that spend a lot
of time sleeping in system calls give a false impression of being
very busy.

That fix is not without drawbacks because the idle flag is set before
libuv makes I/O callbacks and cleared again after. I/O callbacks can
result into calls into JS code and executing JS code is as non-idle
as you can get.

In commit 96ffcb9a21 ("src: reduce cpu profiler overhead") from January
2015, I made Node.js block off the SIGPROF signal that V8's CPU profiler
uses before Node.js goes to sleep. The goal of that commit is to reduce
the overhead from EINTR system call wakeups but it also has the pleasant
side effect of fixing what the idle notifier tried to fix.

This commit removes the idle notifier and turns the JS process object
methods into no-ops.

Fixes: https://github.com/nodejs/node/issues/19009
Refs: https://github.com/nodejs/node/pull/33138

PR-URL: https://github.com/nodejs/node/pull/34010
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: turn AllocatedBuffer into thin wrapper around v8::BackingStore

2020-05-30T23:20:02+00:00

Alternative to https://github.com/nodejs/node/pull/33381 that
reimplements that change on top of moving AllocatedBuffer out
of env.h

PR-URL: https://github.com/nodejs/node/pull/33291
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier

src: refactor Reallocate since it introduced in upstream v8

2020-05-14T14:37:58+00:00

PR-URL: https://github.com/nodejs/node/pull/33402
Reviewed-By: Zeyu Yang 
Reviewed-By: Richard Lau 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: remove unnecessary Isolate::GetCurrent() calls

2020-05-10T12:08:40+00:00

These calls are unnecessary in Release mode but would still have
been included, so move them to the `DebugSealHandleScope` constructor.

PR-URL: https://github.com/nodejs/node/pull/33298
Reviewed-By: Daniel Bevenius 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Michael Dawson

src: use basename(argv0) for --trace-uncaught suggestion

2020-04-15T00:11:43+00:00

Refs: https://github.com/nodejs/node/pull/32797#discussion_r407222290

PR-URL: https://github.com/nodejs/node/pull/32798
Reviewed-By: David Carlier 
Reviewed-By: Richard Lau

src: provide a variant of LoadEnvironment taking a callback

2020-03-21T09:57:23+00:00

This allows embedders to flexibly control how they start JS code
rather than using `third_party_main`.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: align worker and main thread code with embedder API

2020-03-21T09:57:20+00:00

This addresses some long-standing TODOs by Joyee and me about
making the embedder API more powerful and us less reliant on
internal APIs for creating the main thread and Workers.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

src: pass resource object along with InternalMakeCallback

2020-03-04T22:20:57+00:00

This was an oversight in 9fdb6e6aaf45b2364bac89a.
Fixing this is necessary to make `executionAsyncResource()` work
as expected.

Refs: https://github.com/nodejs/node/pull/30959
Fixes: https://github.com/nodejs/node/issues/32060

PR-URL: https://github.com/nodejs/node/pull/32063
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Stephen Belanger 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell

vm: lazily initialize primordials for vm contexts

2020-02-19T05:07:40+00:00

Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: https://github.com/nodejs/node/pull/31738
Fixes: https://github.com/nodejs/node/issues/29842
Reviewed-By: Gus Caplan 
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier

async_hooks: add executionAsyncResource

2020-02-11T19:59:09+00:00

Remove the need for the destroy hook in the basic APM case.

Co-authored-by: Stephen Belanger 
PR-URL: https://github.com/nodejs/node/pull/30959
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell