delta/node-new.git/src/node_i18n.cc, branch try_Python3_on_macOS

src: add error codes to errors thrown in node_i18n.cc

2019-06-21T10:10:48+00:00

PR-URL: https://github.com/nodejs/node/pull/28221
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: use ArrayBufferViewContents more frequently

2019-05-29T17:28:38+00:00

Using `ArrayBufferViewContents` over
`Buffer::Data()`/`Buffer::Length()` or `SPREAD_BUFFER_ARG` has the
advantages of creating fewer individual variables to keep track off,
not being a “magic” macro that creates variables, reducing code size,
and being faster when receiving on-heap TypedArrays.

PR-URL: https://github.com/nodejs/node/pull/27920
Reviewed-By: Ben Noordhuis 
Reviewed-By: Sam Roberts 
Reviewed-By: Colin Ihrig

src: move DiagnosticFilename inlines into a -inl.h

2019-05-26T15:09:45+00:00

DiagnosticFilename's constructor default values use inlines from
env-inl.h, causing the many users of node_internals.h to include
env-inl.h, even if they never use DiagnosticFilename.

PR-URL: https://github.com/nodejs/node/pull/27839
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann

src: remove unused Converter object

2019-03-01T20:40:44+00:00

PR-URL: https://github.com/nodejs/node/pull/26243
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig

src: pass along errors from i18n converter instantiation

2019-01-29T19:02:05+00:00

PR-URL: https://github.com/nodejs/node/pull/25734
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: initialize ICU version in per_process::metadata.versions

2018-12-20T23:46:47+00:00

Instead of

- Initialize the ICU versions in JS land after consulting
  internalBinding('config').hasIntl
- Joining the version keys in C++
- Splitting the keys in JS and call into C++ again to get the value for
  each of the keys

Do:

- Guard the initialization code behind `NODE_HAVE_I18N_SUPPORT`
- Do the initialization in C++ right after ICU data is loaded
- Initialize each version directly using ICU functions/constants,
  and put them in per_process::metadata.versions. These will be
  copied into `process.versions` naturally later.
  This way, the initialization of the versions won't be called
  in worker threads again.

PR-URL: https://github.com/nodejs/node/pull/25115
Reviewed-By: Steven R Loomis 
Reviewed-By: Richard Lau 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell

src: use isolate version of BooleanValue()

2018-12-09T06:42:05+00:00

This fixes deprecation warnings.

PR-URL: https://github.com/nodejs/node/pull/24883
Reviewed-By: Michaël Zasso 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: elevate namespaces of repeated artifacts

2018-11-20T22:51:00+00:00

PR-URL: https://github.com/nodejs/node/pull/24429
Reviewed-By: Refael Ackermann 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani