delta/node-new.git/src/node_i18n.cc, branch main

src: use the internal field to determine if an object is a BaseObject

2023-04-06T00:24:48+00:00

Instead of storing the function template of BaseObject for checking
if an object is BaseObject by calling HasInstance, simply checks
the first internal field of the object, which is always set in the
BaseObject constructor. This is simpler and faster
(there is now no need to iterate over the inheritance for the check).

PR-URL: https://github.com/nodejs/node/pull/47217
Reviewed-By: Chengzhong Wu

src: bootstrap Web [Exposed=*] APIs in the shadow realm

2023-03-15T16:22:06+00:00

This is the initial work to bootstrap Web interfaces that are defined
with extended attributes `[Exposed=*]`.

The ShadowRealm instances are garbage-collected once it is
unreachable. However, V8 can not infer the reference cycles between
the per-realm strong persistent function handles and the realm's
context handle. To allow the context to be gc-ed once it is not
reachable, the per-realm persistent handles are attached to the
context's global object and the persistent handles are set as weak.

PR-URL: https://github.com/nodejs/node/pull/46809
Refs: https://github.com/nodejs/node/issues/42528
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung

src: use explicit C++17 fallthrough

2023-01-20T13:04:52+00:00

This passes the strictest -Wimplicit-fallthrough setting.

PR-URL: https://github.com/nodejs/node/pull/46251
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Jiawen Geng 
Reviewed-By: James M Snell

src: use `enum class` instead of `enum` in node_i18n

2022-11-30T01:23:37+00:00

"enum class" has more advantages than "enum" because
it's strongly typed and scoped.

Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class
PR-URL: https://github.com/nodejs/node/pull/45646
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Minwoo Jung

src: rename internal module declaration as internal bindings

2022-11-28T16:23:08+00:00

This is a continuation of the name reification on the internal bindings.

Renames NODE_MODULE_CONTEXT_AWARE_INTERNAL and
NODE_MODULE_EXTERNAL_REFERENCE to NODE_BINDING_CONTEXT_AWARE_INTERNAL
and NODE_BINDING_EXTERNAL_REFERENCE respectively.

PR-URL: https://github.com/nodejs/node/pull/45551
Refs: https://github.com/nodejs/node/issues/44036
Reviewed-By: Joyee Cheung 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Jacob Smith 
Reviewed-By: Yagiz Nizipli

util: improve text decoder performance

2022-11-12T01:48:29+00:00

PR-URL: https://github.com/nodejs/node/pull/45388
Reviewed-By: Anna Henningsen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Rich Trott

util: improve textdecoder decode performance

2022-11-06T20:27:41+00:00

PR-URL: https://github.com/nodejs/node/pull/45294
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
Reviewed-By: Rich Trott

src: split property helpers from node::Environment

2022-08-01T16:01:02+00:00

PR-URL: https://github.com/nodejs/node/pull/44056
Refs: https://github.com/nodejs/node/issues/42528
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Feng Yu

src: fix to use replacement character

2022-07-29T05:47:56+00:00

PR-URL: https://github.com/nodejs/node/pull/43999
Fixes: https://github.com/nodejs/node/issues/43962
Reviewed-By: Antoine du Hamel 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Feng Yu

src: fix limit calculation

2021-12-10T23:30:08+00:00

Coverity reported that the use of sizeof along with pointer
arithmetic was likely an error as the pointer arithmetic
would already be accounting for the size of what the
pointer points to.

Looking at the code that looked right but removing the
extra sizeOf caused tests to fail.

Looking more closely it seems like we were not allocating
a big enough buffer but the extra sizeof was allowing
us to convert even though it might have been corrupting
memory.

Signed-off-by: Michael Dawson 

PR-URL: https://github.com/nodejs/node/pull/41026
Reviewed-By: Antoine du Hamel