delta/node-new.git/src/node_http_parser.cc, branch sam-github-tsc

src: retrieve binding data from the context

2020-05-06T04:44:04+00:00

Instead of passing them through the data bound to function
templates, store references to them in a list embedded inside
the context.
This makes the function templates more context-independent,
and makes it possible to embed binding data in non-main contexts.

Co-authored-by: Anna Henningsen 

PR-URL: https://github.com/nodejs/node/pull/33139
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: move http parser state out of Environment

2020-04-06T00:06:41+00:00

Moves state that is specific to HTTP/1 into the HTTP/1 implementation
as a cleanup.

PR-URL: https://github.com/nodejs/node/pull/32538
Reviewed-By: James M Snell

http: fix incorrect headersTimeout measurement

2020-04-02T12:50:20+00:00

For keep-alive connections, the headersTimeout may fire during
subsequent request because the measurement was reset after
a request and not before a request.

PR-URL: https://github.com/nodejs/node/pull/32329
Fixes: https://github.com/nodejs/node/issues/27363
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina

src: improve handling of internal field counting

2020-03-02T18:58:36+00:00

Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina

src: inform callback scopes about exceptions in HTTP parser

2020-02-18T01:50:02+00:00

Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61
Refs: https://github.com/nodejs/node/pull/30236
Fixes: https://github.com/nodejs/node/issues/31796

PR-URL: https://github.com/nodejs/node/pull/31801
Reviewed-By: James M Snell 
Reviewed-By: David Carlier

http: strip trailing OWS from header values

2020-02-06T14:22:50+00:00

HTTP header values can have trailing OWS, but it should be stripped.  It
is not semantically part of the header's value, and if treated as part
of the value, it can cause spurious inequality between expected and
actual header values.

Note that a single SPC of leading OWS is common before the field-value,
and it is already handled by the HTTP parser by stripping all leading
OWS. It is only the trailing OWS that must be stripped by the parser
user.

	header-field   = field-name ":" OWS field-value OWS
	    ; https://tools.ietf.org/html/rfc7230#section-3.2
	OWS            = *( SP / HTAB )
	    ; https://tools.ietf.org/html/rfc7230#section-3.2.3

Fixes: https://hackerone.com/reports/730779

PR-URL: https://github.com/nodejs-private/node-private/pull/189
Reviewed-By: Matteo Collina 
Reviewed-By: Fedor Indutny 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

http: llhttp opt-in insecure HTTP header parsing

2019-12-09T17:56:16+00:00

Allow insecure HTTP header parsing. Make clear it is insecure.

See:
- https://github.com/nodejs/node/pull/30553
- https://github.com/nodejs/node/issues/27711#issuecomment-556265881
- https://github.com/nodejs/node/issues/30515

PR-URL: https://github.com/nodejs/node/pull/30567
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen 
Reviewed-By: Denys Otrishko 
Reviewed-By: James M Snell

http: make maximum header size configurable per-stream or per-server

2019-12-01T02:00:46+00:00

Make `maxHeaderSize` a.k.a. `--max-header-size` configurable now that
the legacy parser is gone (which only supported a single global value).

Refs: https://github.com/nodejs/node/pull/30567

PR-URL: https://github.com/nodejs/node/pull/30570
Reviewed-By: Matteo Collina 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: Sam Roberts 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

src: do not use `std::function` for `OnScopeLeave`

2019-11-07T09:39:40+00:00

Using `std::function` adds an extra layer of indirection, and in
particular, heap allocations that are not necessary in our use case
here.

PR-URL: https://github.com/nodejs/node/pull/30134
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell

src: remove AsyncScope and AsyncCallbackScope

2019-11-06T12:57:57+00:00

Reduce the number of different scopes we use for async callbacks.

PR-URL: https://github.com/nodejs/node/pull/30236
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Gus Caplan 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell