delta/node-new.git/src/node_http_parser.cc, branch ofrobots-patch-1

src: fix ToObject() usage in node_http_parser.cc

2018-10-10T14:32:05+00:00

PR-URL: https://github.com/nodejs/node/pull/23314
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10T06:45:56+00:00

This adds missing async_hooks destroy calls for sockets (in
_http_agent.js) and HTTP parsers. We need to emit a destroy in
AsyncWrap#AsyncReset before assigning a new async_id when the instance
has already been in use and is being recycled, because in that case, we
have already emitted an init for the "old" async_id.

This also removes a duplicated init call for HTTP parser: Each time a
new parser was created, AsyncReset was being called via the C++ Parser
class constructor (super constructor AsyncWrap) and also via
Parser::Reinitialize.

PR-URL: https://github.com/nodejs/node/pull/23272
Fixes: https://github.com/nodejs/node/issues/19859
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: replace deprecated uses of FunctionTemplate::GetFunction

2018-09-24T03:44:28+00:00

PR-URL: https://github.com/nodejs/node/pull/22993
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove calls to deprecated v8 functions (IntegerValue)

2018-09-05T11:42:38+00:00

Remove all calls to deprecated v8 functions (here:
Value::IntegerValue) inside the code (src directory only).

Co-authored-by: Michaël Zasso 

PR-URL: https://github.com/nodejs/node/pull/22129
Reviewed-By: Anna Henningsen

src: remove calls to deprecated V8 functions (Int32Value)

2018-09-05T10:59:25+00:00

Remove all calls to deprecated V8 functions (here: Value::Int32Value)
inside the code.

PR-URL: https://github.com/nodejs/node/pull/22662
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell 
Reviewed-By: Ujjwal Sharma

http: move process.binding('http_parser') to internalBinding

2018-08-18T20:01:21+00:00

Refs: https://github.com/nodejs/node/issues/22160

PR-URL: https://github.com/nodejs/node/pull/22329
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Jon Moss 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: add proper MemoryInfoName to wrappers

2018-07-27T07:51:19+00:00

- Use camel case names for memory retainers inherited from AsyncWrap
  instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
  as nodes with class names as node names. Previously some nodes are
  named with reference names, which are supposed to be edge names
  instead.

PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

src: enable more detailed memory tracking

2018-07-13T17:53:15+00:00

This will enable more detailed heap snapshots based on
a newer V8 API.

This commit itself is not tied to that API and could
be backported.

PR-URL: https://github.com/nodejs/node/pull/21742
Reviewed-By: James M Snell