delta/node-new.git/src/node_http2.h, branch sam-github-tsc

src: extract AllocatedBuffer from env.h

2020-05-30T23:20:00+00:00

Cleanup up env.h by removing things that are not
specific to `Environment`.

PR-URL: https://github.com/nodejs/node/pull/33291
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier

http2: refactor and cleanup http2

2020-04-21T20:39:55+00:00

* cleanup constants in http2 binding
  The error constants were just doing some weird things. Cleanup
  and improve maintainability.
* simplify settings to reduce duplicate code
* improve style consistency and correctness
  Use snake_case for getters and setters at c++ level,
  avoid unnecessary use of enums,
  use consistent style for exported vs. internal constants,
  avoid unnecessary memory info reporting,
  use setters/getters for flags_ for improved code readability
* make EmitStatistics function private
* un-nest Http2Settings and Http2Ping
* refactoring and cleanup of Http2Settings and Http2Ping
* avoid ** syntax for readability
  The **session and **stream syntax for getting the underlying
  nghttp2 pointers is not ideal for readability
* use const references for Http2Priority
* remove unnecessary GetStream function
* refactor Http2Scope to use BaseObjectPtr
* move utility function to anonymous namespace
* refactor and simplify Origins
* Use an AllocatedBuffer instead of MaybeStackBuffer
* Use a const reference instead of pointer
* use BaseObjectPtr for Http2Streams map
* move MemoryInfo impl to cc

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32884
Reviewed-By: Matteo Collina 
Reviewed-By: Franziska Hinkelmann

src: add AliasedStruct utility

2020-04-14T00:21:43+00:00

For http2 (and eventually QUIC) we have a struct that is backed
by a v8::BackingStore and exposed to the JavaScript side as an
ArrayBuffer and TypedArray. This is similar to AliasedBuffer
except that it is fronted by a struct on the C++ side.

```c++
struct foo {
  uint32_t ex1;
  uint32_t ex2;
};

AliasedStruct foo_;

foo_->ex1 = 1;
foo_->ex2 = 2;

foo_.GetArrayBuffer();
```

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32778
Reviewed-By: Anna Henningsen 
Reviewed-By: Gerhard Stöbich

src: move HTTP/2 state out of Environment

2020-04-06T00:06:37+00:00

Moves state that is specific to HTTP/2 into the HTTP/2 implementation
as a cleanup.

PR-URL: https://github.com/nodejs/node/pull/32538
Reviewed-By: James M Snell

src: minor http2 refactorings

2020-04-02T16:15:38+00:00

* Simplify Http2Priority struct
* BooleanValue => IsTrue/IsFalse

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32551
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

src: rename http2 class and suppress compile warnings

2020-04-02T16:15:36+00:00

Suppress compile warnings on Windows, rename class for
consistent styling.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32551
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

src: use smart pointers for nghttp2 objects

2020-04-02T16:15:34+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32551
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

src: clean up stream_base.h and stream-base-inl.h

2020-03-19T12:22:53+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32307
Reviewed-By: Anna Henningsen 
Reviewed-By: Jiawen Geng

src: use C++ style for struct with initializers

2020-03-10T06:17:10+00:00

Fixes warning on clang 11:

        In file included from ../../src/node_http2.cc:6:
        ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
        typedef struct {
                      ^
                       SessionJSFields
        ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer
          uint32_t max_invalid_frames = 1000;
                                        ^~~~
        ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration
        } SessionJSFields;
          ^

PR-URL: https://github.com/nodejs/node/pull/32134
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier

src,http2: introduce node_http_common

2020-03-06T15:19:12+00:00

The nghttp2 and nghttp3 (used in the QUIC implementation) share nearly
identical structs for header handling. However, they differ enough that
they need to be handled slightly different in each case. This PR
includes some elements introduced in the QUIC PR separated out to
make them independently reviewable, and updates the http2 implementation
to use the shared utilities.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32069
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina