delta/node-new.git/src/node_http2.cc, branch try_Python3_on_macOS

http2: send out pending data earlier

2019-09-07T04:03:06+00:00

If there’s a lot of data waiting on a given stream, send
it out early, if possible. This helps trigger the backpressure
mechanism introduced in 8a4a1931b8b98 at a better time.

PR-URL: https://github.com/nodejs/node/pull/29398
Reviewed-By: David Carlier 
Reviewed-By: James M Snell

http2: do not start reading after write if new write is on wire

2019-09-04T15:15:24+00:00

Don’t start reading more input data if we’re still busy writing output.
This was overlooked in 8a4a1931b8b98.

Fixes: https://github.com/nodejs/node/issues/29353
Fixes: https://github.com/nodejs/node/issues/29393

PR-URL: https://github.com/nodejs/node/pull/29399
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina

http2: remove security revert flags

2019-08-18T23:09:28+00:00

As the comment in `node_revert.h` indicates, the master branch should
not provide security revert flags.

Refs: https://github.com/nodejs/node/pull/29122

PR-URL: https://github.com/nodejs/node/pull/29141
Reviewed-By: Beth Griggs 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Gus Caplan 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell

http2: remove callback-based padding

2019-08-18T03:13:24+00:00

This option is not useful in practice, as mentioned in comments and the
documentation, because the overhead of calling into JS makes it
unreasonably expensive.

PR-URL: https://github.com/nodejs/node/pull/29144
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

http2: remove unused FlushData() function

2019-08-17T14:31:54+00:00

PR-URL: https://github.com/nodejs/node/pull/29145
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Jiawen Geng 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell

http2: allow security revert for Ping/Settings Flood

2019-08-15T07:51:53+00:00

nghttp2 has updated its limit for outstanding Ping/Settings ACKs
to 1000. This commit allows reverting to the old default of 10000.

The associated CVEs are CVE-2019-9512/CVE-2019-9515.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: pause input processing if sending output

2019-08-15T07:51:53+00:00

If we are waiting for the ability to send more output, we should not
process more input. This commit a) makes us send output earlier,
during processing of input, if we accumulate a lot and b) allows
interrupting the call into nghttp2 that processes input data
and resuming it at a later time, if we do find ourselves in a position
where we are waiting to be able to send more output.

This is part of mitigating CVE-2019-9511/CVE-2019-9517.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: stop reading from socket if writes are in progress

2019-08-15T07:51:53+00:00

If a write to the underlying socket finishes asynchronously, that
means that we cannot write any more data at that point without waiting
for it to finish. If this happens, we should also not be producing any
more input.

This is part of mitigating CVE-2019-9511/CVE-2019-9517.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: consider 0-length non-end DATA frames an error

2019-08-15T07:51:53+00:00

This is intended to mitigate CVE-2019-9518.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

http2: shrink default `vector::reserve()` allocations

2019-08-15T07:51:52+00:00

Allocating memory upfront comes with overhead, and in particular,
`std::vector` implementations do not necessarily return memory
to the system when one might expect that (e.g. after shrinking the
vector).

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell