delta/node-new.git/src/node_file.h, branch pull-request-doc-updates

src: clean clang-tidy errors in node_file.h

2018-10-24T15:52:29+00:00

* explicitly delete move overloads
* default initialize all members
* explicitly discard unused return values
* const some possibles

PR-URL: https://github.com/nodejs/node/pull/23793
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

src: fix resource leak in node::fs::FileHandle

2018-10-24T15:52:22+00:00

PR-URL: https://github.com/nodejs/node/pull/23793
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

src: refactor FillStatsArray

2018-10-24T15:52:15+00:00

PR-URL: https://github.com/nodejs/node/pull/23793
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

fs: implement mkdir recursive (mkdirp)

2018-08-11T19:07:32+00:00

Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: https://github.com/nodejs/user-feedback/pull/70

PR-URL: https://github.com/nodejs/node/pull/21875
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Jon Moss 
Reviewed-By: Ron Korving 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Sam Ruby 
Reviewed-By: Joyee Cheung

src: rename PROVIDER_FSREQWRAP to PROVIDER_FSREQCALLBACK

2018-08-01T19:07:14+00:00

PR-URL: https://github.com/nodejs/node/pull/21971
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src,lib: rename FSReqWrap to FSReqCallback

2018-08-01T19:07:06+00:00

Given that FSReqPromise does not inherit from FSReqWrap, FSReqWrap
should be renamed FSReqCallback to better describe what it does.

First of a few upcoming `fs` refactorings :)

PR-URL: https://github.com/nodejs/node/pull/21971
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: add proper MemoryInfoName to wrappers

2018-07-27T07:51:19+00:00

- Use camel case names for memory retainers inherited from AsyncWrap
  instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
  as nodes with class names as node names. Previously some nodes are
  named with reference names, which are supposed to be edge names
  instead.

PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

src: use offset calc. instead of `req->data` in node_file

2018-07-19T10:11:42+00:00

A small refactor – this removes one layer of pointer indirection.
(The performance gain is likely negligible, the main point here
being that this encapsulates libuv request management a bit more.)

PR-URL: https://github.com/nodejs/node/pull/21839
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen 
Reviewed-By: Jon Moss

src: enable more detailed memory tracking

2018-07-13T17:53:15+00:00

This will enable more detailed heap snapshots based on
a newer V8 API.

This commit itself is not tied to that API and could
be backported.

PR-URL: https://github.com/nodejs/node/pull/21742
Reviewed-By: James M Snell