delta/node-new.git/src/node_file.cc, branch try_Python3_on_macOS

src: turn `GET_OFFSET()` into an inline function

2019-09-02T05:57:06+00:00

There’s no need for this to be a macro.

PR-URL: https://github.com/nodejs/node/pull/29357
Reviewed-By: Jiawen Geng 
Reviewed-By: Masashi Hirano 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau 
Reviewed-By: Michael Dawson

fs: allow int64 offset in fs.write/writeSync/fd.write

2019-08-17T05:09:34+00:00

Ref https://github.com/nodejs/node/issues/26563

PR-URL: https://github.com/nodejs/node/pull/26572
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

fs: use IsSafeJsInt instead of IsNumber for ftruncate

2019-08-17T05:09:32+00:00

PR-URL: https://github.com/nodejs/node/pull/26572
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

fs: allow int64 offset in fs.read/readSync/fd.read

2019-08-17T05:09:27+00:00

Since v10.10.0, 'buf' can be any DataView, meaning the largest
byteLength can be Float64Array.BYTES_PER_ELEMENT * kMaxLength =
17,179,869,176.

'offset' can now be up to 2**53 - 1. This makes it possible to tile
reads into a large buffer.

Breaking: now throws if read offset is not a safe int, is null or
is undefined.

Fixes https://github.com/nodejs/node/issues/26563

PR-URL: https://github.com/nodejs/node/pull/26572
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: allow generic C++ callables in SetImmediate()

2019-07-31T22:51:43+00:00

Modify the native `SetImmediate()` functions to take generic C++
callables as arguments. This makes passing arguments to the callback
easier, and in particular, it allows passing `std::unique_ptr`s
directly, which in turn makes sure that the data they point to is
deleted if the `Environment` is torn down before the callback can run.

PR-URL: https://github.com/nodejs/node/pull/28704
Reviewed-By: James M Snell

module: implement "exports" proposal for CommonJS

2019-07-23T23:11:20+00:00

Refs: https://github.com/jkrems/proposal-pkg-exports/issues/36
Refs: https://github.com/nodejs/node/pull/28568

PR-URL: https://github.com/nodejs/node/pull/28759
Reviewed-By: Guy Bedford 
Reviewed-By: Bradley Farias

fs: add *timeNs properties to BigInt Stats objects

2019-06-13T19:24:41+00:00

- Extend the aliased buffer for stats objects to contain
  the entire time spec (seconds and nanoseconds) for the time
  values instead of calculating the milliseconds in C++ and
  lose precision there.
- Calculate the nanosecond-precision time values in JS and expose
  them in BigInt Stats objects as `*timeNs`. The
  millisecond-precision values are now calculated from the
  nanosecond-precision values.

PR-URL: https://github.com/nodejs/node/pull/21387
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: remove memory_tracker-inl.h from header files

2019-05-23T15:51:39+00:00

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: refactor deprecated UVException in node_file.cc

2019-04-27T07:15:41+00:00

PR-URL: https://github.com/nodejs/node/pull/27280
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig