delta/node-new.git/src/node_file.cc, branch crypto_set_integer_macro

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: unique_ptrs in few lambdas

2018-10-01T04:18:46+00:00

Few lambdas in src/node_file.cc uses conventional
pointers, turn those into unique_ptr semantics

PR-URL: https://github.com/nodejs/node/pull/23124
Reviewed-By: Tobias Nießen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: cache and resue isolate and contex pointers

2018-09-25T05:53:22+00:00

Many places these values are obtained through `env` pointer that
incurs function calls. Source in once and re-use as much as possible.
There are more of this pattern in this file, but those are either
one-time use or used in conditional blocks which means sourcing-in
those data early may not be beneficial.

PR-URL: https://github.com/nodejs/node/pull/23024
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: replace deprecated uses of FunctionTemplate::GetFunction

2018-09-24T03:44:28+00:00

PR-URL: https://github.com/nodejs/node/pull/22993
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: refactor `Environment::GetCurrent()` usage

2018-09-17T15:20:27+00:00

Make `Environment::GetCurrent()` return `nullptr` if the current
`Context` is not a Node.js context, and for the relevant usage of
this function, either:

- Switch to the better `GetCurrent(args)` variant
- Turn functions in to no-ops where it makes sense
- Make it a `CHECK`, i.e. an API requirement, where it make sense
- Leave a `TODO` comment for verifying what, if anything, is to be done

PR-URL: https://github.com/nodejs/node/pull/22819
Reviewed-By: Gus Caplan 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Refael Ackermann

src: rework (mostly internal) functions to use Maybes

2018-09-02T12:25:16+00:00

Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.

Co-authored-by: Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: remove calls to deprecated v8 functions (BooleanValue)

2018-09-01T18:37:08+00:00

Remove all calls to deprecated v8 functions (here:
Value::BooleanValue) inside the code (src directory only).

PR-URL: https://github.com/nodejs/node/pull/22075
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

fs: readdir optionally returning type information

2018-08-14T02:18:45+00:00

readdir and readdirSync now have a "withFileTypes" option, which, when
enabled, provides an array of DirectoryEntry objects, similar to Stats
objects, which have the filename and the type information.

Refs: https://github.com/nodejs/node/issues/15699

PR-URL: https://github.com/nodejs/node/pull/22020
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Roman Reiss 
Reviewed-By: John-David Dalton

fs: implement mkdir recursive (mkdirp)

2018-08-11T19:07:32+00:00

Implements mkdirp functionality in node_file.cc. The Benefit
of implementing in C++ layer is that the logic is more easily
shared between the Promise and callback implementation and
there are notable performance improvements.

This commit is part of the Tooling Group Initiative.

Refs: https://github.com/nodejs/user-feedback/pull/70

PR-URL: https://github.com/nodejs/node/pull/21875
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: Jon Moss 
Reviewed-By: Ron Korving 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Sam Ruby 
Reviewed-By: Joyee Cheung