delta/node-new.git/src/node_errors.h, branch modules-lkgr

esm: minimal resolver spec and implementation refinements

2018-12-04T01:46:29+00:00

PR URL: https://github.com/nodejs/ecmascript-modules/pull/12

src: use custom TryCatch subclass

2018-12-03T16:25:06+00:00

PR-URL: https://github.com/nodejs/node/pull/24751
Reviewed-By: Joyee Cheung

tls: add code for ERR_TLS_INVALID_PROTOCOL_METHOD

2018-12-03T06:38:59+00:00

Add an error code property to invalid `secureProtocol` method
exceptions.

PR-URL: https://github.com/nodejs/node/pull/24729
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

src: move error handling code into node_errors.cc

2018-11-06T12:58:40+00:00

Move the following code into a new node_errors.cc file and
declare them in node_errors.h for clarity and make it possible
to include them with node_errors.h.

- AppendExceptionLine()
- DecorateErrorStack()
- FatalError()
- OnFatalError()
- PrintErrorString()
- FatalException()
- ReportException()
- FatalTryCatch

And move the following definitions (declared elsewhere than
node_errors.h) to node_errors.cc:

- Abort() (in util.h)
- Assert() (in util.h)

PR-URL: https://github.com/nodejs/node/pull/24058
Reviewed-By: Refael Ackermann 
Reviewed-By: Daniel Bevenius

buffer: throw exception when creating from non-Node.js Context

2018-11-04T06:31:03+00:00

Throw an exception instead of crashing when attempting to create
`Buffer` objects from a Context that is not associated with
a Node.js `Environment`.

Possible alternatives for the future might be just returning
a plain `Uint8Array`, or working on providing `Buffer` for all
`Context`s.

PR-URL: https://github.com/nodejs/node/pull/23938
Reviewed-By: James M Snell 
Reviewed-By: Daniel Bevenius

src: minor refactor to node_errors.h

2018-10-28T14:05:10+00:00

Add overloads of the error generation/throwing methods
that take an `Isolate*` argument, since the created objects
don’t depend on the `Environment*` in question.

Also, remove `THROW_ERR_OUT_OF_RANGE_WITH_TEXT`, which did the
same thing as `THROW_ERR_OUT_OF_RANGE` in a more convoluted way.

PR-URL: https://github.com/nodejs/node/pull/23879
Reviewed-By: James M Snell 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Colin Ihrig 
Reviewed-By: Matheus Marchini

errors: use ERR_OUT_OF_RANGE for index errors

2018-09-27T02:36:50+00:00

Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is
capable of providing more detail. (In one instance, use
ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.)

PR-URL: https://github.com/nodejs/node/pull/22969
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: Weijia Wang

src: use `%zx` in printf for size_t

2018-06-14T10:50:40+00:00

This fixes a compiler warning on Windows.

PR-URL: https://github.com/nodejs/node/pull/21323
Reviewed-By: Richard Lau 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Bartosz Sosnowski

src, tools: add check for left leaning pointers

2018-06-07T03:46:51+00:00

This commit adds a rule to cpplint to check that pointers in the code
base lean to the left and not right, and also fixes the violations
reported.

PR-URL: https://github.com/nodejs/node/pull/21010
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

worker: initial implementation

2018-06-06T17:43:52+00:00

Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: https://github.com/ayojs/ayo/pull/110
Refs: https://github.com/ayojs/ayo/pull/114
Refs: https://github.com/ayojs/ayo/pull/117

PR-URL: https://github.com/nodejs/node/pull/20876
Reviewed-By: Gireesh Punathil 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Shingo Inoue 
Reviewed-By: Matteo Collina 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Gus Caplan