delta/node-new.git/src/node_dir.cc, branch sam-github-tsc

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

src: use enum for refed flag on native immediates

2020-05-22T00:47:56+00:00

Refs: https://github.com/nodejs/node/pull/33320#discussion_r423141443

PR-URL: https://github.com/nodejs/node/pull/33444
Reviewed-By: James M Snell 
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Ben Noordhuis

fs: clean up Dir.read() uv_fs_t data before calling into JS

2020-05-15T17:36:48+00:00

A call into JS can schedule another operation on the same `uv_dir_t`.
In particular, when the handle is closed from the callback for a
directory read operation, there previously was a race condition window:

1. A `dir.read()` operation is submitted to libuv
2. The read operation is finished by libuv, calling `AfterDirRead()`
3. We call into JS
4. JS calls dir.close()
5. libuv posts the close request to a thread in the pool
6. The close request runs, destroying the directory handle
7. `AfterDirRead()` is being exited.

Exiting the `FSReqAfterScope` in step 7 attempts to destroy the original
uv_fs_t` from step 1, which now points to an `uv_dir_t` that has
already been destroyed in step 5.

By forcing the `FSReqAfterScope` to clean up before we call into JS,
we can be sure that no other operations on the same `uv_dir_t` are
submitted concurrently.

This addresses issues observed when running with ASAN/valgrind.

PR-URL: https://github.com/nodejs/node/pull/33274
Reviewed-By: Colin Ihrig

src: move fs state out of Environment

2020-04-06T00:06:43+00:00

Moves state that is specific to the `fs` binding into the
`fs` binding implementation as a cleanup.

PR-URL: https://github.com/nodejs/node/pull/32538
Reviewed-By: James M Snell

src: improve handling of internal field counting

2020-03-02T18:58:36+00:00

Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina

src: remove redundant cast in node_dir.cc

2019-12-03T22:21:14+00:00

PR-URL: https://github.com/nodejs/node/pull/30747
Reviewed-By: David Carlier 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: fix node_dir.cc memory allocation

2019-12-03T22:19:14+00:00

PR-URL: https://github.com/nodejs/node/pull/30750
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier

src: clean up node_file.h

2019-11-30T08:51:06+00:00

- Move inline functions into an `-inl.h` file
- Move override function definitions into `.cc` files
- Remove `using` statements from header files
- Make data fields of classes private
- Mark classes at the end of hierarchies as `final`

This is also partially being done in an attempt to avoid
a particular internal compiler error, see
https://github.com/nodejs/node/pull/30475#issuecomment-554740850
for details.

PR-URL: https://github.com/nodejs/node/pull/30530
Reviewed-By: Jiawen Geng 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell

src: remove unused variable in node_dir.cc

2019-11-30T08:39:08+00:00

PR-URL: https://github.com/nodejs/node/pull/30267
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: David Carlier 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Luigi Pinca

fs: add `bufferSize` option to `fs.opendir()`

2019-10-28T13:34:25+00:00

Add an option that controls the size of the internal
buffer.

Fixes: https://github.com/nodejs/node/issues/29941

PR-URL: https://github.com/nodejs/node/pull/30114
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig