delta/node-new.git/src/node_crypto_common.h, branch sam-github-tsc

src: crypto::UseSNIContext to use BaseObjectPtr

2020-04-29T21:36:58+00:00

Extracted from the QUIC PR. Not specific to QUIC.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/33107
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts

src: fix extra includes of "env.h" and "env-inl.h"

2020-04-02T23:17:38+00:00

Due to how the Environment class is used throughout the codebase, there
are a log of includes referencing eitehr env.h or env-inl.h.

This commit cleans up the remaining extra includes of 'env.h' or
'env-inl.h' and adds forward declarations of the Environment class.

PR-URL: https://github.com/nodejs/node/pull/32293
Refs: https://github.com/nodejs/node/issues/27531

Fixes: https://github.com/nodejs/node/issues/27531
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: add node_crypto_common and refactor

2020-03-03T00:27:19+00:00

Two things in one on this commit:

(a) For the QUIC implementation, we need to separate out various bits
    from node_crypto.cc to allow them to be reused. That's where this
    commit starts.

(b) Quite a bit of the node_crypto.cc code was just messy in terms of
    it's organization and lack of error handling and use of Local vs.
    MaybeLocal. This cleans that up a bit and hopefully makes certain
    parts a bit more manageable also.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32016
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts