delta/node-new.git/src/node_crypto_bio.cc, branch try_Python3_on_macOS

src: remove TLS code for unsupported OpenSSLs

2019-06-10T16:23:12+00:00

Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove
ifdefs for previous versions.

PR-URL: https://github.com/nodejs/node/pull/28085
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen

src: remove memory_tracker-inl.h from header files

2019-05-23T15:51:39+00:00

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove internal includes from node_crypto.h

2019-04-02T03:10:46+00:00

Remove headers used by node_crypto.cc that were included in
node_crypto.h. The header file should only include what it uses itself.

PR-URL: https://github.com/nodejs/node/pull/26966
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Richard Lau 
Reviewed-By: Ben Noordhuis

src: apply clang-tidy various improvement

2019-03-10T02:39:08+00:00

* rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc

PR-URL: https://github.com/nodejs/node/pull/26470
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

src: remove cast for unsupported openssl

2019-02-28T21:27:11+00:00

The cast is needed to build against OpenSSL 1.0.2, which master, 11.x,
and 10.x no longer support.

PR-URL: https://github.com/nodejs/node/pull/26305
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: avoid possible race during NodeBIO initialization

2018-08-12T10:58:49+00:00

PR-URL: https://github.com/nodejs/node/pull/21984
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell

src: use smart pointers for NodeBIO

2018-08-12T10:58:37+00:00

PR-URL: https://github.com/nodejs/node/pull/21984
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell

src: add CHECK_NULL/CHECK_NOT_NULL macros

2018-05-26T10:29:31+00:00

This change introduces CHECK_NULL and CHECK_NOT_NULL macros
similar to their definition in v8 and replaces instances of
CHECK/CHECK_EQ/CHECK_NE with these where it seems appropriate.

PR-URL: https://github.com/nodejs/node/pull/20914
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

crypto: remove BIO_set_shutdown

2017-12-11T06:19:55+00:00

I've not been able to find any reason for calling
BIO_set_shutdown(bio, 1). This is done by default for the following
versions of OpenSSL:

https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/
crypto/bio/bio_lib.c#L26

https://github.com/openssl/openssl/blob/OpenSSL_1_0_1/
crypto/bio/bio_lib.c#L90

https://github.com/openssl/openssl/blob/OpenSSL_1_0_2/
crypto/bio/bio_lib.c#L88

https://github.com/openssl/openssl/blob/OpenSSL_1_0_0/
crypto/bio/bio_lib.c#L90

This commit removes the call and the comment.

PR-URL: https://github.com/nodejs/node/pull/17542
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig