delta/node-new.git/src/node_crypto.h, branch sam-github-tsc

crypto: allow KeyObjects in postMessage

2020-06-22T18:50:38+00:00

This change allows sharing KeyObjects between threads via postMessage.
The receiver acquires a new KeyObject and a new KeyObjectHandle, but
refers to the same KeyObjectData:

+-------------------+
| NativeKeyObject 1 | ------------------------------------------+
+-------------------+                                           |
        ^                                                       |
     extends                                                    |
        |                                                       |
+-------------------+    +-------------------+                  |
| KeyObject 1  (JS) | -> | KeyObjectHandle 1 | --------------+  |
+-------------------+    +-------------------+               |  |
                                                             |  |
                                                             |  |
                                                             |  |
                                                             |  |
                                                             |  |
+-------------------+                                        |  |
| NativeKeyObject 2 | ------------------------------------+  |  |
+-------------------+                                     |  |  |
        ^                                                 |  |  |
     extends                                              |  |  |
        |                                                 |  |  |
+-------------------+    +-------------------+            |  |  |
| KeyObject 2  (JS) | -> | KeyObjectHandle 2 | --------+  |  |  |
+-------------------+    +-------------------+         |  |  |  |
                                                       |  |  |  |
                                                       |  |  |  |
                                                       |  |  |  |
                                                       |  |  |  |
                                                       |  |  |  |
+-------------------+                                  |  |  |  |
| NativeKeyObject 3 | ------------------------------+  |  |  |  |
+-------------------+                               |  |  |  |  |
        ^                                           |  |  |  |  |
     extends                                        |  |  |  |  |
        |                                           v  v  v  v  v
+-------------------+    +-------------------+    +---------------+
| KeyObject 3  (JS) | -> | KeyObjectHandle 3 | -> | KeyObjectData |
+-------------------+    +-------------------+    +---------------+

Co-authored-by: Anna Henningsen 

PR-URL: https://github.com/nodejs/node/pull/33360
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: store key data in separate class

2020-06-22T18:50:36+00:00

This separates key handles from the actual key data:

+-----------------+
| NativeKeyObject |
+-----------------+
        ^
     extends
        |
+-----------------+    +-----------------+    +---------------+
| KeyObject  (JS) | -> | KeyObjectHandle | -> | KeyObjectData |
+-----------------+    +-----------------+    +---------------+

PR-URL: https://github.com/nodejs/node/pull/33360
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: add NativeKeyObject base class

2020-06-22T18:50:34+00:00

             +---------------------+
             |     BaseObject      |
             +---------------------+
                        |
                        |
                        |
             +---------------------+
             |   NativeKeyObject   |
             +---------------------+
                        |
                        |
                        |
             +---------------------+
             |      KeyObject      |
             +---------------------+
               /                 \
              /                   \
             /                     \
            /                       \
+---------------------+    +---------------------+
|   SecretKeyObject   |    | AsymmetricKeyObject |
+---------------------+    +---------------------+
                             /                 \
                            /                   \
                           /                     \
                          /                       \
              +---------------------+   +---------------------+
              |   PublicKeyObject   |   |   PrivateKeyObject  |
              +---------------------+   +---------------------+

PR-URL: https://github.com/nodejs/node/pull/33360
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: rename internal key handles to KeyObjectHandle

2020-06-22T18:50:31+00:00

PR-URL: https://github.com/nodejs/node/pull/33360
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: extract AllocatedBuffer from env.h

2020-05-30T23:20:00+00:00

Cleanup up env.h by removing things that are not
specific to `Environment`.

PR-URL: https://github.com/nodejs/node/pull/33291
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier

src: add node_crypto_common and refactor

2020-03-03T00:27:19+00:00

Two things in one on this commit:

(a) For the QUIC implementation, we need to separate out various bits
    from node_crypto.cc to allow them to be reused. That's where this
    commit starts.

(b) Quite a bit of the node_crypto.cc code was just messy in terms of
    it's organization and lack of error handling and use of Local vs.
    MaybeLocal. This cleans that up a bit and hopefully makes certain
    parts a bit more manageable also.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32016
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts

src: move BaseObject subclass dtors/ctors out of node_crypto.h

2020-02-24T15:55:49+00:00

Originally landed in the QUIC repo

Move constructor and destructors for subclasses of `BaseObject`
from node_crypto.h to node_crypto.cc. This removes the need to
include base_object-inl.h when using node_crypto.h in some cases.

Original review metadata:

```
  PR-URL: https://github.com/nodejs/quic/pull/220
  Reviewed-By: Anna Henningsen 
  Reviewed-By: James M Snell 
```

PR-URL: https://github.com/nodejs/node/pull/31872
Reviewed-By: Sam Roberts 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: Tobias Nießen

tls: expose SSL_export_keying_material

2020-02-23T05:21:04+00:00

Fixes: https://github.com/nodejs/node/issues/31802

PR-URL: https://github.com/nodejs/node/pull/31814
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

crypto: fix ieee-p1363 for createVerify

2020-02-23T02:09:55+00:00

Fixes: https://github.com/nodejs/node/issues/31866

PR-URL: https://github.com/nodejs/node/pull/31876
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: don't use deprecated OpenSSL APIs

2019-12-07T21:47:43+00:00

The extra headers are needed when deprecated APIs are disabled as ssl.h
no longer includes them implicitly.

PR-URL: https://github.com/nodejs/node/pull/30812
Reviewed-By: Sam Roberts 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig