delta/node-new.git/src/node_crypto.h, branch crypto_set_integer_macro

src: improve SSL version extraction logic

2018-10-12T04:25:52+00:00

The openssl version as defined in ssl libraries is complex.
The current logic to extract the major.minor.patch format
uses C semantics to loop through the text and search for
specific patterns. Use C++ string to tidy it up.

PR-URL: https://github.com/nodejs/node/pull/23050
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Refael Ackermann 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson

src: revert removal of SecureContext `_external` getter

2018-10-12T04:04:55+00:00

This `_external` getter is essential for some libs to work:
uWebSockets as an example.

PR-URL: https://github.com/nodejs/node/pull/21711
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

crypto: remove node::crypto::CheckResult

2018-10-08T04:20:35+00:00

PR-URL: https://github.com/nodejs/node/pull/23225
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Refael Ackermann 
Reviewed-By: Sakthipriyan Vairamani

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

crypto: deduplicate cipher initialization code

2018-09-26T03:27:02+00:00

CipherBase::Init and CipherBase::InitIv contain a lot of duplicate
code, this commit moves that into a separate function.

PR-URL: https://github.com/nodejs/node/pull/23011
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Ujjwal Sharma

crypto: fix edge case in authenticated encryption

2018-09-18T10:55:07+00:00

Restricting the authentication tag length and calling update or
setAAD before setAuthTag caused an incorrect authentication tag to
be passed to OpenSSL: The auth_tag_len_ field was already set, so
the implementation assumed that the tag itself was known as well.

PR-URL: https://github.com/nodejs/node/pull/22828
Reviewed-By: Daniel Bevenius

crypto: improve setAuthTag

2018-09-02T11:56:25+00:00

This is an attempt to make the behavior of setAuthTag match the
documentation: In GCM mode, it can be called at any time before
invoking final, even after the last call to update.

Fixes: https://github.com/nodejs/node/issues/22421

PR-URL: https://github.com/nodejs/node/pull/22538
Reviewed-By: Anna Henningsen

src: fix external memory usage going negative

2018-09-02T10:48:35+00:00

PR-URL: https://github.com/nodejs/node/pull/22594
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen

src: avoid possible race during NodeBIO initialization

2018-08-12T10:58:49+00:00

PR-URL: https://github.com/nodejs/node/pull/21984
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell

src: add proper MemoryInfoName to wrappers

2018-07-27T07:51:19+00:00

- Use camel case names for memory retainers inherited from AsyncWrap
  instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
  as nodes with class names as node names. Previously some nodes are
  named with reference names, which are supposed to be edge names
  instead.

PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen