delta/node-new.git/src/node_crypto.cc, branch crypto_set_integer_macro

crypto: add SET_INTEGER_CONSTANT macro

2018-10-17T03:38:08+00:00

This commit introduces a SET_INTEGER_CONSTANT macro to reduce some code
duplication in SecureContext::Initialize.

src: remove OCB support ifdef OPENSSL_NO_OCB

2018-10-16T21:26:47+00:00

Electron uses BoringSSL which does not support OCB . It is also
possible to build OpenSSL without support for OCB for Node.js.
This commit disables OCB if OPENSSL_NO_OCB is defined.

PR-URL: https://github.com/nodejs/node/pull/23635
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen

src: throw if functions used as constructors in node_crypto.cc

2018-10-14T20:21:39+00:00

Throw an error if verify_error_getter_templ or
verify_error_getter_templ2 are used as constructors.

PR-URL: https://github.com/nodejs/node/pull/23582
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Tiancheng "Timothy" Gu

crypto: fix length argument to snprintf()

2018-10-13T03:04:54+00:00

Introduced in commit d3d6cd3eca ("src: improve SSL version extraction
logic".)

PR-URL: https://github.com/nodejs/node/pull/23622
Reviewed-By: Anna Henningsen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: James M Snell 
Reviewed-By: Hitesh Kanwathirtha 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Refael Ackermann

src: improve SSL version extraction logic

2018-10-12T04:25:52+00:00

The openssl version as defined in ssl libraries is complex.
The current logic to extract the major.minor.patch format
uses C semantics to loop through the text and search for
specific patterns. Use C++ string to tidy it up.

PR-URL: https://github.com/nodejs/node/pull/23050
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Refael Ackermann 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson

src: revert removal of SecureContext `_external` getter

2018-10-12T04:04:55+00:00

This `_external` getter is essential for some libs to work:
uWebSockets as an example.

PR-URL: https://github.com/nodejs/node/pull/21711
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

benchmark,doc,lib,src,test,tools: fix typos

2018-10-09T13:53:12+00:00

PR-URL: https://github.com/nodejs/node/pull/23302
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

src: remove unneeded variables in node_crypto.cc

2018-10-09T12:33:15+00:00

PR-URL: https://github.com/nodejs/node/pull/23297
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

src: fix ToObject() usage in node_crypto.cc

2018-10-08T21:42:21+00:00

PR-URL: https://github.com/nodejs/node/pull/23298
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

crypto: replace goto SSL_CTX_use_certificate_chain

2018-10-08T03:48:20+00:00

This commit removes the goto statements in SSL_CTX_use_certificate_chain
by using a unique_ptr.

PR-URL: https://github.com/nodejs/node/pull/23113
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell