delta/node-new.git/src/node_crypto.cc, branch Ninja.py-StringIO

crypto: don't expose openssl internals

2019-08-29T04:42:58+00:00

PR-URL: https://github.com/nodejs/node/pull/29325
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen

crypto: handle i2d_SSL_SESSION() error return

2019-08-23T04:35:09+00:00

i2d_SSL_SESSION() can return a value <= 0 when the session is malformed
or otherwise invalid. Handle that case.

This change comes without a regression test because I couldn't figure
out a good way to generate an existing but invalid session in a timely
fashion.

Fixes: https://github.com/nodejs/node/issues/29202

PR-URL: https://github.com/nodejs/node/pull/29225
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

crypto: simplify DSA validation in FIPS mode

2019-08-21T03:18:17+00:00

PR-URL: https://github.com/nodejs/node/pull/29195
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: add error codes to errors thrown in C++

2019-08-09T22:58:58+00:00

PR-URL: https://github.com/nodejs/node/pull/27700
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

crypto: extend RSA-OAEP support with oaepHash

2019-08-07T11:45:42+00:00

This adds an oaepHash option to asymmetric encryption which allows
users to specify a hash function when using OAEP padding. This
feature is required for interoperability with WebCrypto applications.

PR-URL: https://github.com/nodejs/node/pull/28335
Fixes: https://github.com/nodejs/node/issues/25756
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Sam Roberts

crypto: add outputLength option to crypto.createHash

2019-07-26T06:00:41+00:00

This change adds an outputLength option to crypto.createHash which
allows users to produce variable-length hash values using XOF hash
functons.

Fixes: https://github.com/nodejs/node/issues/28757
PR-URL: https://github.com/nodejs/node/pull/28805
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts 
Reviewed-By: Rich Trott

crypto: increase maxmem range from 32 to 53 bits

2019-07-24T04:17:19+00:00

Fixes: https://github.com/nodejs/node/issues/28755

PR-URL: https://github.com/nodejs/node/pull/28799
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

src: fix type name in comment

2019-07-23T16:59:31+00:00

The comment refers to an exception type that JS land throws on the C++
code's behalf but apparently I changed the JS name before landing the
pull request and forgot to update the comment.

Refs: https://github.com/nodejs/node/pull/20816

PR-URL: https://github.com/nodejs/node/pull/28320
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anto Aravinth

crypto: fix crash when calling digest after piping

2019-06-18T16:42:48+00:00

When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in
hash._flush, bypassing safeguards in the JavaScript layer. Calling
hash.digest causes EVP_DigestFinal_ex to be called again, resulting
in a segmentation fault in the SHA3 implementation of OpenSSL.

A relatively easy solution is to cache the result of calling
EVP_DigestFinal_ex until the Hash object is garbage collected.

PR-URL: https://github.com/nodejs/node/pull/28251
Fixes: https://github.com/nodejs/node/issues/28245
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

src: remove TLS code for unsupported OpenSSLs

2019-06-10T16:23:12+00:00

Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove
ifdefs for previous versions.

PR-URL: https://github.com/nodejs/node/pull/28085
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen