delta/node-new.git/src/node_contextify.h, branch try_Python3_on_macOS

src: make `CompiledFnEntry` a `BaseObject`

2019-07-22T18:55:25+00:00

In particular:

- Move the class definition to the relevant header file,
  i.e. `node_contextify.h`.
- Make sure that class instances are destroyed on
  `Environment` teardown.
- Make instances of the key object traceable in heap dumps. This is
  particularly relevant here because our C++ script → map key mapping
  could introduce memory leaks when the import function metadata refers
  back to the script in some way.

Refs: https://github.com/nodejs/node/pull/28671

PR-URL: https://github.com/nodejs/node/pull/28782
Reviewed-By: Gus Caplan 
Reviewed-By: Rich Trott

vm: fix gc bug with modules and compiled functions

2019-07-19T21:45:46+00:00

PR-URL: https://github.com/nodejs/node/pull/28671
Reviewed-By: Anna Henningsen 
Reviewed-By: Guy Bedford

src: add cleanup hook for ContextifyContext

2019-07-14T21:23:33+00:00

Otherwise there’s a memory leak left by the context when the Isolate
tears down without having run the weak callback.

PR-URL: https://github.com/nodejs/node/pull/28631
Reviewed-By: Colin Ihrig 
Reviewed-By: Jeremiah Senkpiel

src: prefer v8::Global over node::Persistent

2019-04-29T22:23:33+00:00

`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.

This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.

PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig

module: revert module._compile to original state if module is patched

2019-02-19T15:28:37+00:00

PR-URL: https://github.com/nodejs/node/pull/21573
Fixes: https://github.com/nodejs/node/issues/17396
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gus Caplan 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: apply clang-tidy rule modernize-use-override

2019-02-18T04:43:22+00:00

PR-URL: https://github.com/nodejs/node/pull/26103
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

inspector,vm: remove --eval wrapper

2019-02-03T19:40:16+00:00

Report the actual source code when running with `--eval` and
`--inspect-brk`, by telling the vm module to break on the
first line of the script being executed rather than wrapping
the source code in a function.

PR-URL: https://github.com/nodejs/node/pull/25832
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung

src: pass along errors from vm data wrapper creation

2019-01-29T19:02:04+00:00

PR-URL: https://github.com/nodejs/node/pull/25734
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove unused method declaration

2019-01-07T07:40:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25329
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell