delta/node-new.git/src/node_contextify.cc, branch ofrobots-patch-1

src: update v8::Object::GetPropertyNames() usage

2018-10-17T16:26:18+00:00

Use the non-deprecated version of GetPropertyNames().

PR-URL: https://github.com/nodejs/node/pull/23660
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Gus Caplan 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

vm: pass parsing_context to ScriptCompiler::CompileFunctionInContext

2018-10-11T06:42:49+00:00

ContextifyContext::CompileFunction in src/node_contextify.cc
was incorrectly passing the context variable to
ScriptCompiler::CompileFunctionInContext

This meant that the parsingContext option in vm.compileFunction
was not being applied properly to the compiled function.

fixes: https://github.com/nodejs/node/issues/23194

doc: clarify parsingContext option for vm.compileScript

test: usage of parsingContext in vm.compileFunction

PR-URL: https://github.com/nodejs/node/pull/23206
Fixes: https://github.com/nodejs/node/issues/23194
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

vm: add dynamic import support

2018-10-06T22:33:25+00:00

PR-URL: https://github.com/nodejs/node/pull/22381
Reviewed-By: James M Snell 
Reviewed-By: Guy Bedford 
Reviewed-By: Tiancheng "Timothy" Gu

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: replace deprecated uses of FunctionTemplate::GetFunction

2018-09-24T03:44:28+00:00

PR-URL: https://github.com/nodejs/node/pull/22993
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

Revert "src: implement query callbacks for vm"

2018-09-18T13:48:02+00:00

This reverts commit 85c356c10eec14f96eaf92ffc9a8481b591e3652
from PR https://github.com/nodejs/node/pull/22390.

See the discussion in the (proposed) fix at
https://github.com/nodejs/node/pull/22836.

Refs: https://github.com/nodejs/node/pull/22836
Refs: https://github.com/nodejs/node/pull/22390
Fixes: https://github.com/nodejs/node/issues/22723

PR-URL: https://github.com/nodejs/node/pull/22911
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Ruben Bridgewater

src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction

2018-08-31T06:37:22+00:00

This is unnecessary, deprecated, and removed in V8 7.0.

PR-URL: https://github.com/nodejs/node/pull/22596
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen

vm: add bindings for v8::CompileFunctionInContext

2018-08-29T14:41:01+00:00

Adds a method compileFunction to the vm module, which serves as a
binding for v8::CompileFunctionInContext with appropriate args for
specifying the details, and provide params for the wrapper.

Eventually, we would be changing Module._compile to use this internally
over the standard Module.wrap

PR-URL: https://github.com/nodejs/node/pull/21571
Reviewed-By: Anna Henningsen 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: John-David Dalton 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell

src,deps: add isolate parameter to String::Concat

2018-08-28T12:11:20+00:00

Partially backport an upstream commit that deprecates String::Concat
without the isolate parameter. This overload has already been removed
in V8 7.0.

PR-URL: https://github.com/nodejs/node/pull/22521
Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Refael Ackermann

src: implement query callbacks for vm

2018-08-24T03:09:19+00:00

This allows using a Proxy object as the sandbox for a VM context.

PR-URL: https://github.com/nodejs/node/pull/22390
Fixes: https://github.com/nodejs/node/issues/17480
Fixes: https://github.com/nodejs/node/issues/17481
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell