delta/node-new.git/src/node_contextify.cc, branch devsnek-patch-1

src: move node_contextify to modern THROW_ERR_*

2020-10-10T15:01:49+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/35470
Reviewed-By: Joyee Cheung

vm: add run-after-evaluate microtask mode

2020-06-26T18:41:33+00:00

This allows timeouts to apply to e.g. `Promise`s and `async function`s
from code running inside of `vm.Context`s, by giving the Context its
own microtasks queue.

Fixes: https://github.com/nodejs/node/issues/3020

PR-URL: https://github.com/nodejs/node/pull/34023
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

src: remove unnecessary ToLocalChecked call

2020-06-22T06:44:50+00:00

PR-URL: https://github.com/nodejs/node/pull/33902
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

vm: allow proxy callbacks to throw

2020-06-11T14:41:36+00:00

Fixes: https://github.com/nodejs/node/issues/33806

PR-URL: https://github.com/nodejs/node/pull/33808
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Colin Ihrig

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

vm: fix vm.measureMemory() and introduce execution option

2020-04-30T09:42:12+00:00

https://github.com/nodejs/node-v8/pull/147 broke the
`vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and
without actually calling `v8::Isolate::MeasureMemory()` so the returned
promise will never resolve. This was not caught by the tests because
the promise resolvers were not wrapped with `common.mustCall()`.

This patch migrates the API properly and also introduce the newly
added execution option to the API. It also removes support for
specifying contexts to measure - instead we'll just return the
measurements for all contexts in the detailed mode, which is
what the `performance.measureMemory()` prototype in V8 currently does.
We can consider implementing our own `v8::MeasureMemoryDelegate`
to select the target context in `ShouldMeasure()` in the future,
but then we'll also need to implement `MeasurementComplete()`
to assemble the result. For now it's probably too early to do that.

Since this API is still experimental (and guarded with a warning),
such breakage should be acceptable.

Refs: https://github.com/nodejs/node-v8/pull/147

PR-URL: https://github.com/nodejs/node/pull/32988
Reviewed-By: Ben Noordhuis 
Reviewed-By: Jiawen Geng 
Reviewed-By: James M Snell

src: use unique_ptr for CachedData in ContextifyScript::New

2020-04-30T02:51:33+00:00

This closes a memory leak.

PR-URL: https://github.com/nodejs/node/pull/33113
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: migrate measureMemory to new v8 api

2020-03-18T23:37:20+00:00

PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso 
Reviewed-By: Jiawen Geng 
Reviewed-By: Ruben Bridgewater

src: improve handling of internal field counting

2020-03-02T18:58:36+00:00

Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina

vm: implement vm.measureMemory() for per-context memory measurement

2020-02-26T09:52:39+00:00

This patch implements `vm.measureMemory()` with the new
`v8::Isolate::MeasureMemory()` API to measure per-context memory
usage. This should be experimental, since detailed memory
measurement requires further integration with the V8 API
that should be available in a future V8 update.

PR-URL: https://github.com/nodejs/node/pull/31824
Refs: https://github.com/ulan/performance-measure-memory
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko 
Reviewed-By: Colin Ihrig