delta/node-new.git/src/node_buffer.h, branch sam-github-tsc

lib,src: switch Buffer::kMaxLength to size_t

2020-01-21T21:55:40+00:00

Change the type of `Buffer::kMaxLength` to size_t because upcoming
changes in V8 will allow typed arrays > 2 GB on 64 bits platforms.

Not all platforms handle file reads and writes > 2 GB though so keep
enforcing the 2 GB typed array limit for I/O operations.

Fixes: https://github.com/nodejs/node/issues/31399
Refs: https://github.com/libuv/libuv/pull/1501

PR-URL: https://github.com/nodejs/node/pull/31406
Reviewed-By: Richard Lau 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen 
Reviewed-By: Shelley Vohr

src: expose ArrayBuffer version of Buffer::New()

2019-11-19T13:02:22+00:00

This can be useful to create `Buffer` instances for already-existing
`ArrayBuffer`s, e.g. ones created manually from a backing store
with a free callback (of which our variant in the public API has
some limitations).

PR-URL: https://github.com/nodejs/node/pull/30476
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell

src: remove public API for option variables

2018-10-03T21:08:06+00:00

PR-URL: https://github.com/nodejs/node/pull/23069
Reviewed-By: Gus Caplan 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Shingo Inoue 
Reviewed-By: Refael Ackermann

src: deprecate option variables in public API

2018-09-02T15:37:54+00:00

These variables should never have been exposed as part of the
public API, and certainly not as variables. Using CLI options
parser is the right thing to do here, at least until we expose
some part of the options parser API publicly (which should be
possible to do now).

PR-URL: https://github.com/nodejs/node/pull/22515
Reviewed-By: Gus Caplan 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: Tobias Nießen 
Reviewed-By: Ruben Bridgewater

src: refactor options parsing

2018-08-22T21:37:19+00:00

This is a major refactor of our Node’s parser. See `node_options.cc`
for how it is used, and  `node_options-inl.h` for the bulk
of its implementation.

Unfortunately, the implementation has come to have some
complexity, in order to meet the following goals:

- Make it easy to *use* for defining or changing options.
- Keep it (mostly) backwards-compatible.
  - No tests were harmed as part of this commit.
- Be as consistent as possible.
  - In particular, options can now generally accept arguments
    through both `--foo=bar` notation and `--foo bar` notation.
    We were previously very inconsistent on this point.
- Separate into different levels of scope, namely
  per-process (global), per-Isolate and per-Environment
  (+ debug options).
- Allow programmatic accessibility in the future.
  - This includes a possible expansion for `--help` output.

This commit also leaves a number of `TODO` comments, mostly for
improving consistency even more (possibly with having to modify
tests), improving embedder support, as well as removing pieces of
exposed configuration variables that should never have become
part of the public API but unfortunately are at this point.

PR-URL: https://github.com/nodejs/node/pull/22392
Reviewed-By: Matteo Collina 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength

2018-04-04T06:09:51+00:00

This was added in v8 6.2, looks like a safe replacement for
our own buffer::kMaxLength.

PR-URL: https://github.com/nodejs/node/pull/19738
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: do not include internals from node_buffer.h

2017-09-22T14:28:52+00:00

`node_buffer.h` is a public header, so it should not be using
the `node_internals.h` internal header.

Ref: 290315ace7eed6eeeb300754dd68fc1af4d80c9b
Fixes: https://github.com/nodejs/node/issues/15552
PR-URL: https://github.com/nodejs/node/pull/15554
Reviewed-By: Matteo Collina 
Reviewed-By: Andreas Madsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Gibson Fahnestock

src: refactor `#include` handling

2017-09-14T15:38:38+00:00

`node_internals.h` already includes the most common headers,
so double includes can be avoided in a lot of cases. Also don’t include
`node_internals.h` from `node.h` implicitly anymore, as that is mostly
unnecessary.

PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

buffer: remove a wrongly added attribute specifier

2017-07-29T22:00:56+00:00

It doesn't seem to make much sense to have the mentioned typedef
declaration equipped with NODE_EXTERN. In fact, when compiling with GCC,
an attribute specifier like __attribute__((visibility("default"))) in
such a typedef declaration will cause the following warning message:

  warning: ‘visibility’ attribute ignored [-Wattributes]

The issue goes unnoticed because NODE_EXTERN is defined as nothing for
GCC builds, but for correctness it's better to not specify it here at
all.

PR-URL: https://github.com/nodejs/node/pull/14466
Reviewed-By: Refael Ackermann 
Reviewed-By: Trevor Norris

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.