delta/node-new.git/src/node_buffer.cc, branch crypto_set_integer_macro

buffer: move process.binding('buffer') to internalBinding

2018-10-15T11:01:20+00:00

PR-URL: https://github.com/nodejs/node/pull/22370
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen

src: remove public API for option variables

2018-10-03T21:08:06+00:00

PR-URL: https://github.com/nodejs/node/pull/23069
Reviewed-By: Gus Caplan 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Shingo Inoue 
Reviewed-By: Refael Ackermann

errors: use ERR_OUT_OF_RANGE for index errors

2018-09-27T02:36:50+00:00

Remove ERR_INDEX_OUT_OF_RANGE in favor of ERR_OUT_OF_RANGE which is
capable of providing more detail. (In one instance, use
ERR_BUFFER_OUT_OF_BOUNDS which is more accurate in that one instance.)

PR-URL: https://github.com/nodejs/node/pull/22969
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: Weijia Wang

src: remove calls to SetWrapperClassId()

2018-09-23T23:26:11+00:00

We have migrated from the deprecated RetainedObjectInfo API to
the new EmbedderGraph API, so there is no need to take care
of wrapper class ids anymore since they are dedicated to the
deprecated API (the new API uses a graph instead of ids to retrieve
info about nodes).

PR-URL: https://github.com/nodejs/node/pull/22975
Refs: https://github.com/nodejs/node/pull/21741
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: refactor `Environment::GetCurrent()` usage

2018-09-17T15:20:27+00:00

Make `Environment::GetCurrent()` return `nullptr` if the current
`Context` is not a Node.js context, and for the relevant usage of
this function, either:

- Switch to the better `GetCurrent(args)` variant
- Turn functions in to no-ops where it makes sense
- Make it a `CHECK`, i.e. an API requirement, where it make sense
- Leave a `TODO` comment for verifying what, if anything, is to be done

PR-URL: https://github.com/nodejs/node/pull/22819
Reviewed-By: Gus Caplan 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Refael Ackermann

src: remove calls to deprecated v8 functions (IntegerValue)

2018-09-05T11:42:38+00:00

Remove all calls to deprecated v8 functions (here:
Value::IntegerValue) inside the code (src directory only).

Co-authored-by: Michaël Zasso 

PR-URL: https://github.com/nodejs/node/pull/22129
Reviewed-By: Anna Henningsen

src: allow UTF-16 in generic StringBytes decode call

2018-09-03T20:33:42+00:00

This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: https://github.com/nodejs/node/issues/22358

PR-URL: https://github.com/nodejs/node/pull/22622
Reviewed-By: Tobias Nießen

src: remove calls to deprecated v8 functions (Uint32Value)

2018-09-02T14:32:15+00:00

Remove all calls to deprecated v8 functions (here:
Value::Uint32Value) inside the code (src directory only).

PR-URL: https://github.com/nodejs/node/pull/22143
Reviewed-By: Anna Henningsen 
Reviewed-By: Denys Otrishko

src: rework (mostly internal) functions to use Maybes

2018-09-02T12:25:16+00:00

Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.

Co-authored-by: Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: use String::Utf8Length with isolate

2018-08-29T10:28:19+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell