delta/node-new.git/src/node_buffer.cc, branch Ninja.py-StringIO

src: inline `SLICE_START_END()` in node_buffer.cc

2019-09-02T05:56:56+00:00

This macro is only used once, so it doesn’t need to be a macro.

PR-URL: https://github.com/nodejs/node/pull/29357
Reviewed-By: Jiawen Geng 
Reviewed-By: Masashi Hirano 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau 
Reviewed-By: Michael Dawson

buffer: consolidate encoding parsing

2019-08-28T19:13:38+00:00

PR-URL: https://github.com/nodejs/node/pull/29217
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen

src: add error codes to errors thrown in C++

2019-08-09T22:58:58+00:00

PR-URL: https://github.com/nodejs/node/pull/27700
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

src: use ArrayBufferViewContents more frequently

2019-05-29T17:28:38+00:00

Using `ArrayBufferViewContents` over
`Buffer::Data()`/`Buffer::Length()` or `SPREAD_BUFFER_ARG` has the
advantages of creating fewer individual variables to keep track off,
not being a “magic” macro that creates variables, reducing code size,
and being faster when receiving on-heap TypedArrays.

PR-URL: https://github.com/nodejs/node/pull/27920
Reviewed-By: Ben Noordhuis 
Reviewed-By: Sam Roberts 
Reviewed-By: Colin Ihrig

src: prefer v8::Global over node::Persistent

2019-04-29T22:23:33+00:00

`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.

This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.

PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig

src: fix check for accepting Buffers into Node’s allocator

2019-04-14T21:06:48+00:00

This condition was incorrect. We currently take the fallback
path in default Node builds, which always works, but may come with
some overhead, whereas the intention was that we use the fast path
in this condition.

This is causing issues for embedders, because we would erroneously
try to take the fast path when they don’t provide a Node.js-style
`ArrayBufferAlloactor`, and crash as a consequence of that.

This also requires us to relax the check in the debugging ArrayBuffer
allocator a bit, because since d117e41e50667d7a36, 0-sized ArrayBuffers
may actually point to allocations of size 1. Previously, that wasn’t
caught because the fallback path circumvented our ArrayBufferAllocator.

Refs: https://github.com/nodejs/node/commit/84e02b178ad14fae0df2a514e8a39bfa50ffdc2d#r33116006

PR-URL: https://github.com/nodejs/node/pull/27174
Reviewed-By: Joyee Cheung 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: inline macro DISALLOW_COPY_AND_ASSIGN

2019-03-18T01:58:22+00:00

PR-URL: https://github.com/nodejs/node/pull/26634
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

embedding: refactor public `ArrayBufferAllocator` API

2019-03-13T09:14:14+00:00

Use a RAII approach by default, and make it possible for embedders
to use the `ArrayBufferAllocator` directly as a V8
`ArrayBuffer::Allocator`, e.g. when passing to `Isolate::CreateParams`
manually.

PR-URL: https://github.com/nodejs/node/pull/26525
Reviewed-By: Gireesh Punathil 
Reviewed-By: Joyee Cheung

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell