delta/node-new.git/src/node_binding.cc, branch try_Python3_on_macOS

src: use thread_local to declare modpending

2019-07-02T23:14:59+00:00

The pointer used to hold an incoming dynamically loaded module's
`node::node_module` structure needs to be thread-local. So far this was
done with `uv_key_set()` and `uv_key_get()`. The language now supports
the `thread_local` keyword which makes implementing this a lot cleaner.

PR-URL: https://github.com/nodejs/node/pull/28456
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen

src, lib: take control of prepareStackTrace

2019-05-21T20:39:09+00:00

Refs https://crbug.com/v8/7848

PR-URL: https://github.com/nodejs/node/pull/23926
Reviewed-By: Refael Ackermann 
Reviewed-By: Joyee Cheung

src: make a Environment-independent proxy class for NativeModuleLoader

2019-04-13T09:24:51+00:00

This patch splits `NativeModuleLoader` into two parts - a singleton
that only relies on v8 and `node::Mutex` and a proxy class for
the singleton (`NativeModuleEnv`) that provides limited access to
the singleton as well as C++ bindings for the Node.js binary.
`NativeModuleLoader` is then no longer aware of `Environment`.

PR-URL: https://github.com/nodejs/node/pull/27160
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

lib: move DTRACE_* probes out of global scope

2019-03-12T14:19:36+00:00

The DTRACE_* probes have been global for no really good reason.
Move those into an internalBinding.

PR-URL: https://github.com/nodejs/node/pull/26541
Reviewed-By: Anna Henningsen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Matteo Collina 
Reviewed-By: Matheus Marchini 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater

src: refactor coverage connection

2019-03-11T23:03:53+00:00

- Refactor the C++ class to be resuable for other types of profiles
- Move the try-catch block around coverage collection callback
  to be inside the callback to silence potential JSON or write
  errors.
- Use Function::Call instead of MakeCallback to call the coverage
  message callback since it does not actually need async hook
  handling. This way we no longer needs to disable the async
  hooks when writing the coverage results.
- Renames `lib/internal/coverage-gen/with_profiler.js` to
  `lib/internal/profiler.js` because it is now the only way
  to generate coverage.

PR-URL: https://github.com/nodejs/node/pull/26513
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Coe

worker: improve integration with native addons

2019-02-22T20:42:09+00:00

Allow loading add-ons from multiple Node.js instances if they are
declared context-aware; in particular, this applies to N-API addons.

Also, plug a memory leak that occurred when registering N-API addons.

Refs: https://github.com/nodejs/node/pull/23319

PR-URL: https://github.com/nodejs/node/pull/26175
Fixes: https://github.com/nodejs/node/issues/21481
Fixes: https://github.com/nodejs/node/issues/21783
Fixes: https://github.com/nodejs/node/issues/25662
Fixes: https://github.com/nodejs/node/issues/20239
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Richard Lau

process: start coverage collection before bootstrap

2019-02-18T09:37:33+00:00

This patch moves the dispatch of `Profiler.takePreciseCoverage`
to a point before the bootstrap scripts are run to ensure that
we can collect coverage data for all the scripts run after
the inspector agent is ready.

Before this patch `lib/internal/bootstrap/primordials.js` was not
covered by `make coverage`, after this patch it is.

PR-URL: https://github.com/nodejs/node/pull/26006
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Coe 
Reviewed-By: James M Snell

src,lib: remove dead `process.binding()` code

2019-02-03T19:41:53+00:00

There are no non-internal builtin modules left, so this
should be safe to remove to a large degree.

PR-URL: https://github.com/nodejs/node/pull/25829
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anto Aravinth 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell