delta/node-new.git/src/node_api.cc, branch crypto_set_integer_macro

src: replace deprecated uses of FunctionTemplate::GetFunction

2018-09-24T03:44:28+00:00

PR-URL: https://github.com/nodejs/node/pull/22993
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: refactor `Environment::GetCurrent()` usage

2018-09-17T15:20:27+00:00

Make `Environment::GetCurrent()` return `nullptr` if the current
`Context` is not a Node.js context, and for the relevant usage of
this function, either:

- Switch to the better `GetCurrent(args)` variant
- Turn functions in to no-ops where it makes sense
- Make it a `CHECK`, i.e. an API requirement, where it make sense
- Leave a `TODO` comment for verifying what, if anything, is to be done

PR-URL: https://github.com/nodejs/node/pull/22819
Reviewed-By: Gus Caplan 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Refael Ackermann

n-api: add generic finalizer callback

2018-09-13T02:37:42+00:00

Add `napi_add_finalizer()`, which provides the ability to attach data
to an arbitrary object and be notified when that object is garbage-
collected so as to have an opportunity to delete the data previously
attached.

This differs from `napi_wrap()` in that it does not use up the private
slot on the object, and is therefore neither removable, nor retrievable
after the call to `napi_add_finalizer()`. It is assumed that the data
is accessible by other means, yet it must be tied to the lifetime of
the object. This is the case for data passed to a dynamically created
function which is itself heap-allocated and must therefore be freed
along with the function.

Fixes: https://github.com/nodejs/abi-stable-node/issues/313
PR-URL: https://github.com/nodejs/node/pull/22244
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: make `FIXED_ONE_BYTE_STRING` an inline fn

2018-09-10T03:30:13+00:00

This prevents accidental usage on non-fixed strings.

PR-URL: https://github.com/nodejs/node/pull/22725
Reviewed-By: Daniel Bevenius 
Reviewed-By: Minwoo Jung 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell

n-api: clean up thread-safe function

2018-08-31T19:52:15+00:00

* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

PR-URL: https://github.com/nodejs/node/pull/22259
Reviewed-By: Anna Henningsen 
Reviewed-By: Kyle Farnung 
Reviewed-By: Michael Dawson

src: use String::Utf8Length with isolate

2018-08-29T10:28:19+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use String::Write{OneByte,Utf8} with isolate

2018-08-29T10:28:14+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src,deps: add isolate parameter to String::Concat

2018-08-28T12:11:20+00:00

Partially backport an upstream commit that deprecates String::Concat
without the isolate parameter. This overload has already been removed
in V8 7.0.

PR-URL: https://github.com/nodejs/node/pull/22521
Refs: https://github.com/v8/v8/commit/8a011b57d8b26e9cfe1c20a2ef26adb14be6ecc2
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Refael Ackermann

n-api: remove idle_running from TsFn

2018-08-28T11:47:08+00:00

The idle_running member variable in TsFn is always false and can
therefore be removed.

PR-URL: https://github.com/nodejs/node/pull/22520
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Gus Caplan

src: fix may be uninitialized warning in n-api

2018-07-28T03:08:51+00:00

PR-URL: https://github.com/nodejs/node/pull/21898
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Jon Moss 
Reviewed-By: Luigi Pinca