delta/node-new.git/src/node.h, branch try_Python3_on_macOS

src: expose MaybeInitializeContext to allow existing contexts

2019-08-27T01:24:10+00:00

Splits the node.js specific tweak intialization of NewContext into a new
helper MaybeInitializeContext so that embedders with existing contexts
can still use them in a Node.js Environment now that primordials are
initialized and required so early.

Update MaybeInitializeContext to return MaybeLocal,

PR-URL: https://github.com/nodejs/node/pull/28544
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

src: lint #defines in src/node.h

2019-07-14T22:22:56+00:00

A few #defines in src/node.h had inconsistent spacing
and tabbing. This commit changes the spacing to be
the same style as the rest of the project.

PR-URL: https://github.com/nodejs/node/pull/28547
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Michaël Zasso

src: forbid reset_handler for SIGSEGV handling

2019-06-14T17:11:41+00:00

This is not easily implementable, and should be explicitly disallowed.

PR-URL: https://github.com/nodejs/node/pull/27775
Refs: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: do not use posix feature macro in node.h

2019-06-14T17:11:39+00:00

This macro is only defined when building Node.js, so addons cannot
use it as a way of detecting feature availability.

PR-URL: https://github.com/nodejs/node/pull/27775
Refs: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: remove util-inl.h include in node.h

2019-05-21T21:24:49+00:00

`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: https://github.com/nodejs/node/pull/27631
Fixes: https://github.com/nodejs/node/issues/27803

PR-URL: https://github.com/nodejs/node/pull/27804
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Sam Roberts 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Richard Lau

src: enable V8's WASM trap handlers

2019-05-16T17:52:53+00:00

This uses SIGSEGV handlers to catch WASM out of bound (OOB) memory
accesses instead of inserting OOB checks inline, resulting in a 25%-30%
speed increase.

Note that installing a custom SIGSEGV handler will break this, resulting
in potentially scary behaviour.

Refs: https://github.com/nodejs/node/issues/14927

PR-URL: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: do not require JS Context for `~AsyncResoure()`

2019-04-24T19:38:40+00:00

Allow the destructor to be called during GC,
which is a common use case.

PR-URL: https://github.com/nodejs/node/pull/27255
Fixes: https://github.com/nodejs/node/issues/27218
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: add `Environment` overload of `EmitAsyncDestroy`

2019-04-24T19:38:38+00:00

This can be necessary for being able to call the function when no
JS Context is on the stack, e.g. during GC.

Refs: https://github.com/nodejs/node/issues/27218

PR-URL: https://github.com/nodejs/node/pull/27255
Fixes: https://github.com/nodejs/node/issues/27218
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann